Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OntoUploader into an Interface #15

Closed
lewismc opened this issue May 16, 2017 · 4 comments
Closed

Refactor OntoUploader into an Interface #15

lewismc opened this issue May 16, 2017 · 4 comments

Comments

@lewismc
Copy link
Member

lewismc commented May 16, 2017

The OntoUploader.java code should be refactored into an Interface with individual implementations for both ESIP COR AND ESIP Semantic Portal. The implementation should be driven by a configuration file which is read from src/main/resources via an InputStream. All credentials for interfacing with the various ontology repositories should also then be added there as well.

@graybeal
Copy link

You may find useful a bit of CEDAR's terminology server (https://github.com/metadatacenter/cedar-terminology-server), particular the part that submits value sets to BioPortal. (Unfortunately, no code in there to submit ontologies to BioPortal.)
API documentation at https://terminology.metadatacenter.net/api/, particularly https://terminology.metadatacenter.net/api/#!/Value32sets/put_value_sets_id for submitting the value sets.

@lewismc lewismc removed their assignment May 17, 2017
@lewismc
Copy link
Member Author

lewismc commented May 17, 2017

@graybeal thank you Sir.

@lewismc
Copy link
Member Author

lewismc commented May 17, 2017

@Yongyao do you want to take this issue on? I am working on #13

@lewismc
Copy link
Member Author

lewismc commented May 17, 2017

After we do that, I think we should release 0.1 to Maven Central.

@Yongyao Yongyao self-assigned this May 17, 2017
@lewismc lewismc assigned lewismc and unassigned Yongyao Dec 13, 2017
@lewismc lewismc closed this as completed Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants