German Translation

[Sharlikran]

• Menu settings

[Sharlikran]

@svenpanne okay there are some new strings for the latest release. When you have time can you take a look please? Reference the master branch, and make the pull request on a new branch like you did before please.

[Sharlikran]

@svenpanne There are some new strings for the latest release. When you have time can you take a look please? Reference the master branch, and make the pull request on a new branch like you did before please.

MasterMerchant\i18n\DE.lua
MasterMerchant\Libs\LibGuildStore\i18n\DE.lua

[Baertram]

Hey @Sharlikran, here is my updated DE.lua, as of 2022-01-17
Master Merchant
DE.lua.txt

Some questions:
You could improve EN.lua at this constant here to include "1 day ago":
ZO_CreateStringId("SK_TIME_DAYS", "<<1[Yesterday/1 day ago/%d days ago]>>"
)

Is this text still actual or was LibGuoldRoster updated and the additional "reloadui .." text can be removed?
ZO_CreateStringId("MM_GUILD_ROSTER_OPTIONS_TIP", "Enable and disable the different guild roster columns. (Reload UI required until next update of LibGuild Roster)")

If this reloadui text is obsolete you can change the DE.lua at the constant MM_GUILD_ROSTER_OPTIONS_TIP and just remove the \n\n(....) at the end of the String.

[Baertram]

For LibGuildStore:
DE translations as of 2022-01-17.

LibGuildStore_DE.lua.txt

Seems a lot of them are duplicate with MM?
Maybe remove the MM texts that are duplicate in the library and just use the strings from the library in MM as well, as the lib seems to be a needed dependency for MM?
This would reduce the redundantly needed translations.
Or just update the MM texts with the library texts like this:
ZO_CreateStringId("MM_DAYS_ONLY_NAME", GetString(GS_DAYS_ONLY_NAME))

And these strings are given by the base game and should not be re-translated again:
ZO_CreateStringId("GS_ALL_BUTTON", "All")
ZO_CreateStringId("GS_WEAPONS_BUTTON", "Weapons")
ZO_CreateStringId("GS_ARMOR_BUTTON", "Armor")
ZO_CreateStringId("GS_JEWELRY_BUTTON", "Jewelry")
ZO_CreateStringId("GS_CONSUMABLE_BUTTON", "Consumable")
ZO_CreateStringId("GS_CRAFTING_BUTTON", "Materials")
ZO_CreateStringId("GS_FURNISHING_BUTTON", "Furnishing")
ZO_CreateStringId("GS_COMPANION_BUTTON", "Companion")
ZO_CreateStringId("GS_UNKNOWN_BUTTON", "Unknown")

Just use the default texts for them in your en.lua, found here:
https://raw.githubusercontent.com/esoui/esoui/master/esoui/ingamelocalization/localizegeneratedstrings.lua

e.g.
"All", -- SI_ITEMTYPEDISPLAYCATEGORY0
"Weapons", -- SI_ITEMTYPEDISPLAYCATEGORY1
"Armor", -- SI_ITEMTYPEDISPLAYCATEGORY2
"Jewelry", -- SI_ITEMTYPEDISPLAYCATEGORY3
"Consumables", -- SI_ITEMTYPEDISPLAYCATEGORY4
"Materials", -- SI_ITEMTYPEDISPLAYCATEGORY5
"Furnishings", -- SI_ITEMTYPEDISPLAYCATEGORY6
"Miscellaneous", -- SI_ITEMTYPEDISPLAYCATEGORY7
"Companion", -- SI_QUESTTYPE16
"Unknown", -- SI_INPUT_LANGUAGE_UNKNOWN

I think those are duplicate and the 2nd is wrong ?
ZO_CreateStringId("GS_ATT_PURCHASE_DATA_MISSING", "Arkadius Trade Tools Purchases Data Not Found.")
ZO_CreateStringId("GS_ATT_PURCHASE_DATA_IMPORTED", "Arkadius Trade Tools Purchases Data Not Found.")

Should be something like:
ZO_CreateStringId("GS_ATT_PURCHASE_DATA_MISSING", "Arkadius Trade Tools Purchases Data Not Found.")
ZO_CreateStringId("GS_ATT_PURCHASE_DATA_IMPORTED", "Arkadius Trade Tools Purchases Data was imported.")

[Sharlikran]

If I use your file with the .txt extension as is it is not maintaining your UTF8 setting. Either it was not set or GitHub did something so the file looses the special characters.

After I commit the change if any special chars are missing use the new file from GitHub and add them please.

[Baertram]

Weird, it looked normal for me and was UTF-8 in my editor.
I have reviewed the file in your update and hey look okay. I have added some missing translations about ShoppingList, which I had skipped by accident.

I've send a pull reuqest for that: #39