Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel order should be respected (and maybe also pip dependency order) #117

Closed
sdvillal opened this issue Oct 4, 2020 · 1 comment · Fixed by #203
Closed

Channel order should be respected (and maybe also pip dependency order) #117

sdvillal opened this issue Oct 4, 2020 · 1 comment · Fixed by #203

Comments

@sdvillal
Copy link

sdvillal commented Oct 4, 2020

At the moment everything is sorted alphanumerically in the rendered environment. I think it is not correct:

  • channel priorities should be respected
  • pip dependencies order should maybe be somewhat respected (since pip is, at the moment and until it gets the promised resolver, sensitive to the order in which we ask for dependencies)

I guess the way to go for includes, at least for channels, would be to have a simple consistency check and fail if two channels are ordered differently in different files.

Thanks for conda-devenv!

@nicoddemus
Copy link
Member

Thanks @sdvillal, you are correct, we should not be ordering channel and pip dependencies. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants