Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take the custom _includes/head.html out of RSQkit again #175

Closed
egpbos opened this issue Dec 18, 2024 · 5 comments · Fixed by #227
Closed

take the custom _includes/head.html out of RSQkit again #175

egpbos opened this issue Dec 18, 2024 · 5 comments · Fixed by #227
Assignees

Comments

@egpbos
Copy link
Contributor

egpbos commented Dec 18, 2024

In #170, we added a custom head.html to disable Matomo cookies. Hopefully, ETT will merge ELIXIR-Belgium/elixir-toolkit-theme#314 which builds this functionality into ETT itself. If that happens, we can remove the customized head.html from RSQkit and just add the matomo_cookies: false line to config.yml to disable the cookies here.

@shoaibsufi
Copy link
Collaborator

Check pinned version and update accordingly in the config file

@anenadic
Copy link
Contributor

anenadic commented Jan 24, 2025

Current version of the ETT theme is 4.1.0 - are we ready to update this in the config file @egpbos? There are a few other bug fixes in this release of the theme that would make RSQKit look better.

Related to #202.

@egpbos
Copy link
Contributor Author

egpbos commented Jan 24, 2025

Yes, we are ready to upgrade. If you are going to upgrade only, please keep this issue open so I will remember to also clean up the then deprecated custom head file.

@anenadic
Copy link
Contributor

I was going to let you clean up the custom _includes/head.html and bump up the theme version at the same time (after testing) so we cn close both issues at the same time. How does that sound @egpbos?

@egpbos
Copy link
Contributor Author

egpbos commented Jan 24, 2025

Works for me! I won't have time today I fear, but I'll get to it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants