Auth: Catch all exceptions while waiting for token validation and reject it instead of crashing #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wku12
requested review from
Pietfried,
corneliusclaussen and
hikinggrass
as code owners
Signed-off-by: Wojciech Kula <[email protected]>
wku12
force-pushed
the
fix/auth_module_crash_when_token_validator_timesout
branch
from
59765d2 to
5311cf6
Compare
Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
approved these changes
Jan 29, 2025
| try { | ||
| const auto result = token_validator->call_validate_token(provided_token); | ||
| validation_results.push_back(result); | ||
| // TODO: This is very broad catch, make it more narrow when the everest-framework error handling will be |
There was a problem hiding this comment.
For the record, this refers to EVerest/everest-framework#210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Now instead of letting exceptions crash whole EVerest, we catch it and reject the token if any exception was raised by token_validator and/or everest
Issue ticket number and link
#1024
Checklist before requesting a review