Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device model get_value per component #993

Open
maaikez opened this issue Feb 20, 2025 · 0 comments
Open

Device model get_value per component #993

maaikez opened this issue Feb 20, 2025 · 0 comments
Labels
enhancement New feature or request OCPP2.1

Comments

@maaikez
Copy link
Contributor

maaikez commented Feb 20, 2025

OCPP Version

OCPP2.0.1

Describe the problem

There are RequiredComponentVariables in the device model, that are only required when the Component they belong to is required as well. It is easy to forget the check to see if the component is 'Available' before accessing the RequiredComponentVariable.

To make sure RequiredComponentVariable is not accessed when the Component does not exist, the code should be changed so the RequiredComponentVariables belong to a Component. If the component is not available, no variable can be requested.

Describe your solution

Rewrite DeviceModel, so the call to get a variable would then be something like:
this->device_model->aligned_data_ctrlr->get_value(...)
or something similar.

Additional context

No response

@maaikez maaikez added enhancement New feature or request OCPP2.1 labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OCPP2.1
Projects
None yet
Development

No branches or pull requests

1 participant