Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: properly support "empty" StAX element #44

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

danielpeintner
Copy link
Member

fixes #43

@jsbiff
Copy link

jsbiff commented Jan 18, 2025

Hello. I cloned this branch to try to test it. After the clone, in the exificient dir, I tried "mvn install" to build and install the new version into my mvn repo so I could then, hopefully, try to use it in place of the release version, as a dependency (I'm a more than a bit of a novice to mvn, but trying to figure it out).

It appears to me that mvn encountered a build error - also, it appears that github is also reporting build errors (I see an error above, on this page "1 failing check".

So, I don't think I can test this, because it's not buildable.

My local maven gave this error:

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.76 sec - in com.siemens.ct.exi.main.data.BugTestCase

Results :

Tests in error: 
  ParallelTest.testParallelDecodeWithParTaskFactory:300->testParallelDecode:307->getExiSch:353->decodeExiToDoc:198 » EXI
  ParallelTest.testParallelDecodeWithThreadLocalFactory:295->testParallelDecode:325 » Execution

Tests run: 628, Failures: 0, Errors: 2, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:09 min
[INFO] Finished at: 2025-01-18T10:30:33-05:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test (default-test) on project exificient: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/jeff/src/exificient/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

UPDATE: Well, I figured out that I can skip the tests with: mvn install -DskipTests , so I used that to force the build to finish and install, so I will attempt to test now that way - but seems like you should try to fix the tests eventually so that the tests don't fail. I suppose perhaps you are awaiting results of my manual testing, before attempting to update the tests in source?

UPDATE 2: So, as I mentioned on the other ticket, I was under the mistaken impression I was cloning directly to the issue-43 branch. Turns out I cloned to the 'main' branch, and had to switch locally to the issue-43 branch and rebuild exificient to test the fix. Sorry, it's been awhile since I used git/github with branches. I got it sorted in the end though.

But, it appears even the issue-43 branch also gets the test errors, so I still had to force mvn to skip the tests to install and test it. But, my test was a success, and passed.

@danielpeintner
Copy link
Member Author

Your lasted "update" means it is working as expected, right?

@jsbiff
Copy link

jsbiff commented Jan 20, 2025

@danielpeintner - yes, that's right. Sorry about the confusion.

@danielpeintner danielpeintner merged commit e7c2f00 into master Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StAXEncoder.writeAttribute() putting attributes on wrong element?
2 participants