Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate command before executing #3

Closed
kirtangajjar opened this issue Jul 19, 2018 · 3 comments
Closed

Validate command before executing #3

kirtangajjar opened this issue Jul 19, 2018 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@kirtangajjar
Copy link
Contributor

kirtangajjar commented Jul 19, 2018

While executing cron commands, If the command would contain ; or #, then everything that comes after it will be ignored(till end of line) since ofelia uses INI style config in which both of them are treated as comments(and hence everything that follows it is ignored)

i.e. In a job like this:

[job-exec "abc.test-touch__tmp_a-Jdhbn"]
schedule = * * * * *
container = abctest_php_1
command = touch /tmp/a.txt ; touch /tmp/b.txt

touch /tmp/b.txt will never be called.

@rahul286
Copy link
Member

rahul286 commented Jul 21, 2018

@kirtangajjar can we use quotes or escaping?

Like "touch /tmp/a.txt ; touch /tmp/b.txt"
or touch /tmp/a.txt \; touch /tmp/b.txt

@mbtamuli mbtamuli added the bug Something isn't working label Jul 27, 2018
@kirtangajjar
Copy link
Contributor Author

@rahul286 Nope. That doesn't work :(

@mbtamuli
Copy link
Contributor

mbtamuli commented Aug 6, 2018

Validation has been taken care of in #9.

As for allowing the syntax, it is being tracked in #10

@mbtamuli mbtamuli closed this as completed Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants