Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design API for "complex" event commands #157

Open
Ghabry opened this issue Jan 25, 2021 · 1 comment
Open

Design API for "complex" event commands #157

Ghabry opened this issue Jan 25, 2021 · 1 comment

Comments

@Ghabry
Copy link
Member

Ghabry commented Jan 25, 2021

From an editor point of view there are two types of event commands:

Basic event commands: The event only operates on there data (Currently the API only supports this)

There are two types of complex commands:

E.g. Message Command & Comment

  • The commands following the main command are lines belonging to it

E.g. Branches

  • They can add/delete if/else branches directly after the command
@Ghabry
Copy link
Member Author

Ghabry commented Jan 25, 2021

Main problem here is that the widget that shows the EventCommands is very fragile.
It takes pointers to event commands for each item in the tree. So a complex manipulation will have many dangling pointers and crash sooner or later.
So before solving this the Event command widget must be refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant