Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwaterC in Multiple Modules #29

Open
kewalak opened this issue Sep 19, 2023 · 3 comments
Open

TwaterC in Multiple Modules #29

kewalak opened this issue Sep 19, 2023 · 3 comments
Labels
question Further information is requested

Comments

@kewalak
Copy link
Contributor

kewalak commented Sep 19, 2023

TwaterC is used in multiple modules (tsm, nsm1, etc). Need to make sure it can be shared across modules.

Also need to make surface_area and Volume (from tsm) shared to calculated depth used in many nsm1 modules.

@imscw95
Copy link
Contributor

imscw95 commented Sep 29, 2023

I am thinking of the 'state variables' as any variable that gets re-computed by the CWR engine and passed back to the modules. That would go for surface_area, volume, TwaterC, and all other constituents that are transported, and hydraulic properties that are needed in the modules (e.g. velocity). These could all live in one file in our modules that gets imported to each processes file, and gets updated by the relevant process. That would mean our state_variable file would need to import each module_processes file in order to update the values. To me this seems like a viable option.

@xaviernogueira
Copy link
Contributor

@kewalak no worries if you don't have the answer now, but is it shared as in you would run TSM and NSM at the same time, or is it just that NSM also have a state variable TwaterC?

@xaviernogueira xaviernogueira added the question Further information is requested label Oct 11, 2023
@kewalak
Copy link
Contributor Author

kewalak commented Oct 12, 2023

@xaviernogueira NSM just uses the variable TwaterC. I am assuming they could run at the same time and NSM would calculate based on the current timestep not the new TwaterC value calculated in TSM (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants