add fsm example traffic light #623
Conversation
add fsm examples traffic light test
huerni
requested review from
saiyan86,
seanli33056,
tomqin93,
BtXin and
kris21he
as code owners
|
@huerni I think you've done a great job for a mocking the traffic light behavior with well format readme file. |
|
Hi @huerni the overall PR looks good, however, we actually was hoping this issue to be done after the previous FSM implementation issue: #542. Sorry for the confusion here. |
| PROCEED string = "PROCEED" | ||
| ) | ||
|
|
||
| type TrafficLight struct { |
There was a problem hiding this comment.
@huerni, to be more specific, assume the trafficlight is the edgedevice, the question would turn to - how can the FSM control this edge device?
Here you wrote a mock device that have the feature we've described while our final goal is try to make the FSM can be applied to any edge device.
There was a problem hiding this comment.
I apologize for the confusion, I'm not very familiar with edge devices and FSM either. To clarify, are you asking if it's possible to write an FSM controller that can be used for any edge device? Or are you suggesting that each edge device should be able to quickly build its own FSM?
There was a problem hiding this comment.
We are going to have a proper design for the FSM feature in the following weeks. You can refer to the design for implementation details.
add fsm examples traffic light test
What this PR does / why we need it:
Add traffic light shifudevice to fsm examples, you can communicate with traffic light shifudevice through nginx
Will this PR make the community happier?
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #fixes #547
How is this PR tested
Special notes for your reviewer:
Release note: