Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shifu should allow user to configure / instruction #949

Open
tomqin93 opened this issue Aug 8, 2024 · 1 comment
Open

Shifu should allow user to configure / instruction #949

tomqin93 opened this issue Aug 8, 2024 · 1 comment

Comments

@tomqin93
Copy link
Contributor

tomqin93 commented Aug 8, 2024

Is your feature request related to a problem? Please describe.

Currently when a user tries to configure deviceShifu with / instruction, it conflicts with the embedded instructionNotFoundHandler which cannot be overwritten and throws an error.

Describe the solution you'd like

Allow user to configure / as an instruction

Describe alternatives you've considered

Use another forward proxy in front of Shifu

Additional context
@tomqin93 tomqin93 changed the title Shifu should allow user to configure / as path Shifu should allow user to configure / instruction Aug 8, 2024
@saiyan86
Copy link
Contributor

@tomqin93 assign?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomqin93 @saiyan86