Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EgorBot for EgorBo in #111806 #254

Open
EgorBot opened this issue Jan 24, 2025 · 3 comments
Open

EgorBot for EgorBo in #111806 #254

EgorBot opened this issue Jan 24, 2025 · 3 comments

Comments

@EgorBot
Copy link
Owner

EgorBot commented Jan 24, 2025

Processing dotnet/runtime#111806 (comment) command:

Command

-arm -amd -intel --envvars DOTNET_TieredPGO:0

using BenchmarkDotNet.Attributes;

public class Benchmarks
{
    [Benchmark]
    [ArgumentsSource(nameof(TestData))]
    public bool EqualsTest(string a, string b) => a == b;

    public static IEnumerable<object[]> TestData()
    {
        // Compare long same strings
        string longStr =
            "Lorem ipsum odor amet, consectetuer adipiscing elit. Litora conubia mi vestibulum " +
            "dis justo egestas potenti praesent. Neque quis sollicitudin, tellus dui egestas cras. " +
            "Commodo mi maximus gravida; lacinia consequat suspendisse diam finibus. Ante pharetra " +
            "volutpat risus elit dui blandit amet porta dapibus. Hac urna tellus interdum dapibus " +
            "suspendisse eget platea lacus vitae? Aliquam suspendisse curae fusce penatibus a. " +
            "Suspendisse quis quis rhoncus finibus amet. Suscipit aliquam ipsum vulputate lacinia" +
            " suscipit euismod sagittis auctor. Neque quis sollicitudin, tellus dui egestas cras. " +
            "Commodo mi maximus gravida; lacinia consequat suspendisse diam finibus. Ante pharetra " +
            "volutpat risus elit dui blandit amet porta dapibus. Hac urna tellus interdum dapibus " +
            "suspendisse eget platea lacus vitae? Aliquam suspendisse curae fusce penatibus a. " +
            "Suspendisse quis quis rhoncus finibus amet. Suscipit aliquam ipsum vulputate lacinia" +
            " suscipit euismod sagittis auctor.";

        yield return [longStr + "1", longStr + "2"]; // different ending to make sure the instances aren't the same
    }
}

(EgorBot will reply in this issue)

@EgorBot
Copy link
Owner Author

EgorBot commented Jan 24, 2025

Benchmark results on linux_azure_genoa

BenchmarkDotNet v0.14.0, Ubuntu 24.04.1 LTS (Noble Numbat)
AMD EPYC 9V74, 1 CPU, 16 logical and 8 physical cores
  Job-LDTIOE : .NET 10.0.0 (42.42.42.42424), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
  Job-BFRZCP : .NET 10.0.0 (42.42.42.42424), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
EnvironmentVariables=DOTNET_TieredPGO=0
Method Toolchain a b Mean Error Ratio
EqualsTest Main Lore(...)or.1 [962] Lore(...)or.2 [962] 31.54 ns 0.061 ns 1.00
EqualsTest PR Lore(...)or.1 [962] Lore(...)or.2 [962] 26.78 ns 0.308 ns 0.85

BDN_Artifacts.zip

cc @EgorBo (agent_logs.txt). EgorBot manual: link.

@EgorBot
Copy link
Owner Author

EgorBot commented Jan 24, 2025

Benchmark results on linux_azure_cascadelake

BenchmarkDotNet v0.14.0, Ubuntu 24.04.1 LTS (Noble Numbat)
Intel Xeon Platinum 8370C CPU 2.80GHz, 1 CPU, 16 logical and 8 physical cores
  Job-WTTPVT : .NET 10.0.0 (42.42.42.42424), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
  Job-YZYCQD : .NET 10.0.0 (42.42.42.42424), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
EnvironmentVariables=DOTNET_TieredPGO=0  StdDev=0.005 ns
Method Toolchain a b Mean Error Ratio
EqualsTest Main Lore(...)or.1 [962] Lore(...)or.2 [962] 32.66 ns 0.005 ns 1.00
EqualsTest PR Lore(...)or.1 [962] Lore(...)or.2 [962] 26.90 ns 0.006 ns 0.82

BDN_Artifacts.zip

cc @EgorBo (agent_logs.txt). EgorBot manual: link.

@EgorBot
Copy link
Owner Author

EgorBot commented Jan 24, 2025

❌ Failed on AzureCobalt100: Job failed, see logs.

cc @EgorBo (logs). EgorBot manual: link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant