Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FireFox tab detection is currently unsupported within Windows #3

Open
Electrenator opened this issue Feb 11, 2022 · 2 comments
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Electrenator
Copy link
Owner

Electrenator commented Feb 11, 2022

Would like that this program would also work within Windows. However currently the paths for detecting this on Windows aren't setup or even known to me, since I've not been near Windows a lot lately.

What should be changed to allow for this change?

A path should be added to the following array that indicates the (probably dynamic) Windows location for the Firefox recovery files. This should be added into the src/browser/firefox.py tab locations array shown below.

this.possible_tab_locations = [
# Firefox GNU/Linux (Ubuntu & Fedora tested)
"~/.mozilla/firefox*/*.default*/sessionstore-backups/recovery.jsonlz4",
]

@Electrenator Electrenator added enhancement New feature or request good first issue Good for newcomers labels Feb 11, 2022
@Electrenator
Copy link
Owner Author

Since this issue describes something from quite some time ago, this may be more work than described. Currently unsure if the proposed solution would work first try. Still don't have windows so have not been able to check it's behaviour on there out yet

@Electrenator Electrenator removed the good first issue Good for newcomers label May 10, 2023
@Electrenator Electrenator added the help wanted Extra attention is needed label Sep 11, 2023
@Electrenator
Copy link
Owner Author

Not something I will be able to do. Not running windows at all anymore. Assigning help wanted tag for that reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant