Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure detekt #22

Closed
ccjernigan opened this issue Apr 19, 2022 · 0 comments · Fixed by #47
Closed

Configure detekt #22

ccjernigan opened this issue Apr 19, 2022 · 0 comments · Fixed by #47

Comments

@ccjernigan
Copy link
Contributor

This should come after #18.
ccjernigan added a commit that referenced this issue Apr 21, 2022
@ccjernigan
[#23] Add basic GitHub Actions workflows
2317b8e 
Note that static analysis is commented out until it is implemented in #21 and #22.

Maven deployment will be enabled once secrets are added.
@ccjernigan ccjernigan mentioned this issue Apr 21, 2022
Merged
ccjernigan added a commit that referenced this issue Apr 21, 2022
@ccjernigan
[#23] Add basic GitHub Actions workflows
a9be103 
Note that static analysis is commented out until it is implemented in #21 and #22.

Maven deployment will be enabled once secrets are added.
ccjernigan added a commit that referenced this issue Apr 22, 2022
@ccjernigan
[#23] Add basic GitHub Actions workflows
9684ff0 
Note that static analysis is commented out until it is implemented in #21 and #22.

Maven deployment will be enabled once secrets are added.
ccjernigan added a commit that referenced this issue Apr 28, 2022
@ccjernigan
[#23] Add basic GitHub Actions workflows
f294ff8 
Note that static analysis is commented out until it is implemented in #22.

Maven deployment will be enabled once secrets are added.
ccjernigan added a commit that referenced this issue May 2, 2022
@ccjernigan
[#22] Configure Detekt
9316048 
Followup work includes:
 - #46
@ccjernigan ccjernigan linked a pull request May 2, 2022 that will close this issue
[#22] Configure Detekt #47
Merged
10 tasks
ccjernigan added a commit that referenced this issue May 4, 2022
@ccjernigan
[#23] Add basic GitHub Actions workflows
925d80f 
Note that static analysis is commented out until it is implemented in #22.

Maven deployment will be enabled once secrets are added.
ccjernigan added a commit that referenced this issue May 4, 2022
@ccjernigan
[#22] Configure Detekt
989515e 
Followup work includes:
 - #46
ccjernigan added a commit that referenced this issue May 4, 2022
@ccjernigan
[#22] Configure Detekt
bdda959 
 - Followup issue #46

Added a baseline file to suppress warnings for existing issues, while enabling Detekt to run on CI so that new issues won't be introduced going forward.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#22] Configure Detekt Electric-Coin-Company/kotlin-bip39
1 participant
@ccjernigan