Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RootView to use SwitchStore #698

Open
LukasKorba opened this issue Mar 27, 2023 · 0 comments
Open

RootView to use SwitchStore #698

LukasKorba opened this issue Mar 27, 2023 · 0 comments
Assignees
@LukasKorba

Comments

@LukasKorba
Copy link
Collaborator

The current implementation of the RootView uses switch over enum but TCA has a concept of a SwitchStore that is exactly useful for this case. Use of enums with appropriate states helps to clear out the syntax and be more TCA way.
@LukasKorba LukasKorba self-assigned this Mar 28, 2023
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 29, 2023
@LukasKorba
[Electric-Coin-Company#698] RootView to use SwitchStore
f75b159 
- draft of idea for the alerts

[Electric-Coin-Company#698] RootView to use SwitchStore

- concept of filter action
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 30, 2023
@LukasKorba
[Electric-Coin-Company#698] RootView to use SwitchStore
bd2667d 
- draft of idea for the alerts

[Electric-Coin-Company#698] RootView to use SwitchStore

- concept of filter action

[Electric-Coin-Company#698] RootView to use SwitchStore

- functional alerts, WIP

[Electric-Coin-Company#698] RootView to use SwitchStore

- all alerts refactored and connected
- onChange replaced with side effects

[Electric-Coin-Company#698] RootView to use SwitchStore

- unit tests fixed
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 30, 2023
@LukasKorba
[Electric-Coin-Company#698] RootView to use SwitchStore
51b2996 
- draft of idea for the alerts

[Electric-Coin-Company#698] RootView to use SwitchStore

- concept of filter action

[Electric-Coin-Company#698] RootView to use SwitchStore

- functional alerts, WIP

[Electric-Coin-Company#698] RootView to use SwitchStore

- all alerts refactored and connected
- onChange replaced with side effects

[Electric-Coin-Company#698] RootView to use SwitchStore

- unit tests fixed

[Electric-Coin-Company#698] RootView to use SwitchStore

- cleanup
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 30, 2023
@LukasKorba
[Electric-Coin-Company#698] RootView to use SwitchStore
3d8080d 
- draft of idea for the alerts

[Electric-Coin-Company#698] RootView to use SwitchStore

- concept of filter action

[Electric-Coin-Company#698] RootView to use SwitchStore

- functional alerts, WIP

[Electric-Coin-Company#698] RootView to use SwitchStore

- all alerts refactored and connected
- onChange replaced with side effects

[Electric-Coin-Company#698] RootView to use SwitchStore

- unit tests fixed

[Electric-Coin-Company#698] RootView to use SwitchStore

- cleanup

[Electric-Coin-Company#698] RootView to use SwitchStore

- simplifying the export logs actions
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 30, 2023
@LukasKorba
[Electric-Coin-Company#698] RootView to use SwitchStore
25796d3 
- draft of idea for the alerts

[Electric-Coin-Company#698] RootView to use SwitchStore

- concept of filter action

[Electric-Coin-Company#698] RootView to use SwitchStore

- functional alerts, WIP

[Electric-Coin-Company#698] RootView to use SwitchStore

- all alerts refactored and connected
- onChange replaced with side effects

[Electric-Coin-Company#698] RootView to use SwitchStore

- unit tests fixed

[Electric-Coin-Company#698] RootView to use SwitchStore

- cleanup

[Electric-Coin-Company#698] RootView to use SwitchStore

- simplifying the export logs actions

[Electric-Coin-Company#698] RootView to use SwitchStore

- export logs 2nd location captured as well
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 30, 2023
@LukasKorba
[Electric-Coin-Company#698] RootView to use SwitchStore
017151b 
- draft of idea for the alerts

[Electric-Coin-Company#698] RootView to use SwitchStore

- concept of filter action

[Electric-Coin-Company#698] RootView to use SwitchStore

- functional alerts, WIP

[Electric-Coin-Company#698] RootView to use SwitchStore

- all alerts refactored and connected
- onChange replaced with side effects

[Electric-Coin-Company#698] RootView to use SwitchStore

- unit tests fixed

[Electric-Coin-Company#698] RootView to use SwitchStore

- cleanup

[Electric-Coin-Company#698] RootView to use SwitchStore

- simplifying the export logs actions

[Electric-Coin-Company#698] RootView to use SwitchStore

- export logs 2nd location captured as well
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 30, 2023
@LukasKorba
[Electric-Coin-Company#698] RootView to use SwitchStore
401d62f 
- draft of idea for the alerts

[Electric-Coin-Company#698] RootView to use SwitchStore

- concept of filter action

[Electric-Coin-Company#698] RootView to use SwitchStore

- functional alerts, WIP

[Electric-Coin-Company#698] RootView to use SwitchStore

- all alerts refactored and connected
- onChange replaced with side effects

[Electric-Coin-Company#698] RootView to use SwitchStore

- unit tests fixed

[Electric-Coin-Company#698] RootView to use SwitchStore

- cleanup

[Electric-Coin-Company#698] RootView to use SwitchStore

- simplifying the export logs actions

[Electric-Coin-Company#698] RootView to use SwitchStore

- export logs 2nd location captured as well

[Electric-Coin-Company#630] Investigate possibility to implement AlertReducer (Electric-Coin-Company#699)

- readding files
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Mar 30, 2023
@LukasKorba
[Electric-Coin-Company#698] RootView to use SwitchStore
b0d37e2 
- draft of idea for the alerts

[Electric-Coin-Company#698] RootView to use SwitchStore

- concept of filter action

[Electric-Coin-Company#698] RootView to use SwitchStore

- functional alerts, WIP

[Electric-Coin-Company#698] RootView to use SwitchStore

- all alerts refactored and connected
- onChange replaced with side effects

[Electric-Coin-Company#698] RootView to use SwitchStore

- unit tests fixed

[Electric-Coin-Company#698] RootView to use SwitchStore

- cleanup

[Electric-Coin-Company#698] RootView to use SwitchStore

- simplifying the export logs actions

[Electric-Coin-Company#698] RootView to use SwitchStore

- export logs 2nd location captured as well

[Electric-Coin-Company#630] Investigate possibility to implement AlertReducer (Electric-Coin-Company#699)

- readding files

[Electric-Coin-Company#630] Investigate possibility to implement AlertReducer (Electric-Coin-Company#699)

- fixed project
LukasKorba added a commit that referenced this issue Mar 31, 2023
@LukasKorba
[#698] RootView to use SwitchStore (#699)
36d2090 
- all alerts refactored and connected
- unit tests fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasKorba LukasKorba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LukasKorba