Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger the ReviewRequest logic #704

Open
LukasKorba opened this issue Apr 4, 2023 · 0 comments
Open

Trigger the ReviewRequest logic #704

LukasKorba opened this issue Apr 4, 2023 · 0 comments

Comments

@LukasKorba
Copy link
Collaborator

LukasKorba commented Apr 4, 2023 •
edited by daira
Loading

The system rating dialog support has been implemented in #265 but is disconnected until the team decides to bring this feature to the production/test flight app.

Triggering of the logic is pretty simple, we just need to call proper Home actions, ideally from Root's didFinishLaunching as

EffectTask(value: .home(.resolveReviewRequest))

We also need to connect sdkSynchronizer.eventStream() and look for case foundTransactions. When valid, we pass

EffectTask(value: .home(.foundTransactions))

to the Home.
LukasKorba added a commit to LukasKorba/secant-ios-wallet that referenced this issue Apr 4, 2023
@LukasKorba
[Electric-Coin-Company#265] Integrate App Rating Alert
606b333 
- update of SPM

[Electric-Coin-Company#265] Integrate App Rating Alert

- async adaptations of the latest sdk
- review request TCA dependency added
- set of rules for the triggering the app rating dialog
- deeplinks commented out for now
- WIP for the tests

[Electric-Coin-Company#265] Integrate App Rating Alert

- unit tests fixed
- deeplinks fixed

[Electric-Coin-Company#265] Integrate App Rating Alert

- unit tests for the review request client
- app review request logic disconnected from the production for now

[Electric-Coin-Company#265] Integrate App Rating Alert (Electric-Coin-Company#704)

- added the TODO for the triggering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LukasKorba