Birthday height is not being respected as the sync start point.

[nuttycom]

Describe the issue

When entering a wallet birthday for wallet recovery, the birthday height appears to be accepted but thereafter the wallet seems to be fully synced, even when the birthday height is millions of blocks in the past.

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

1. Open the debug screen
2. Nuke wallet
3. Restore wallet (enter seed)
4. Enter wallet birthday

Expected behaviour

The wallet sync should proceed from the birthday height.

Actual behaviour + errors

• App Version: TestFlight build 60

The wallet appears to be fully synced.

[nuttycom]

This bug appears to only be reachable from the "nuke wallet -> restore" flow; when I nuke the wallet, then uninstall the app and reinstall, the "restore wallet" flow from the onboarding screen seems to work correctly.

[LukasKorba]

I think there is a bug somewhere else. I see wallet birthday to be set, it's passed to the Initializer + stored to the keychain. But syncing was somewhat broken when I tried these 4 steps. I suspect wipe doesn't work perfectly, not resetting some context. Will investigate it further. For me also the deletion of the app and reinstall started to work (which effectively is clean start, perfect reset that probably is not after wipe)