Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable support for using Zashi on Apple Silicon macs #877

Open
daira opened this issue Oct 26, 2023 · 4 comments
Open

Re-enable support for using Zashi on Apple Silicon macs #877

daira opened this issue Oct 26, 2023 · 4 comments
Assignees
Labels
O-macos Operating system: macOS

Comments

@daira
Copy link
Contributor

daira commented Oct 26, 2023

This was disabled in Appstore Connect because additional work is required to make input work correctly. Note that LSMinimumSystemVersion will also need to be set to 13.0.

@daira daira changed the title Re-enable support for Zashi on Apple Silicon macs Re-enable support for using Zashi on Apple Silicon macs Oct 26, 2023
@zookozcash
Copy link

zookozcash commented Oct 27, 2023

Whether we are going to re-enable support for Zashi on Mac or not remains to be decided. Next step: Dir/Eng (currently me) talks to str4d.

@daira daira added the O-macos Operating system: macOS label Aug 19, 2024
@daira
Copy link
Contributor Author

daira commented Aug 19, 2024

This was disabled in Appstore Connect because additional work is required to make input work correctly.

I believe this was #1013, for which I've suggested a workaround:

Assuming it is actually caused by autocomplete / "inline predictive text", a user can probably work around it by turning that off globally. That said, it's obviously still a bug in the app, relative to other macOS apps.

Another possibility is to have the app turn off autocomplete for all fields that it affects:

textField.autocorrectionType = .no
textField.spellCheckingType = .no

This could be done conditionally if the app is running on macOS:

The isiOSAppOnMac property of ProcessInfo tells you whether your iOS app is running in macOS or iOS, but checking that property should always be your last choice. It’s better to run the same code on both platforms.

@daira
Copy link
Contributor Author

daira commented Aug 19, 2024

It's up to @true-jared and @LukasKorba to decide whether to reprioritize this. (Just clarifying that Zooko's comment is obsolete.)

@tw0po1nt
Copy link
Contributor

I'd really like to see this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-macos Operating system: macOS
Projects
None yet
Development

No branches or pull requests

4 participants