Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite FocusState to be testable with the latest TCA #943

Open
LukasKorba opened this issue Nov 24, 2023 · 0 comments
Open

Rewrite FocusState to be testable with the latest TCA #943

LukasKorba opened this issue Nov 24, 2023 · 0 comments
Labels
C-tech-debt Technical debt that should be paid-in-full, eventually.

Comments

@LukasKorba
Copy link
Collaborator

The TCA has a workaround for the FocusStates, we use it in the seed phrase recovery and more importantly in send flow. @focusstate is unfortunately forced by SwiftUI to be local in the View only. TCA 1.x.x resolved this problem with special binding between TCA focus and view @focusstate.
@LukasKorba LukasKorba added the C-tech-debt Technical debt that should be paid-in-full, eventually. label Nov 26, 2023
@nuttycom nuttycom added this to the Zashi 1.0 milestone Jan 3, 2024
@nuttycom nuttycom modified the milestones: Zashi 1.0, iOS Zashi 1.0 Feb 9, 2024
@nuttycom nuttycom modified the milestones: iOS Zashi 1.0, iOS Zashi 1.1 Apr 1, 2024
@LukasKorba LukasKorba removed this from the iOS Zashi 1.1 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tech-debt Technical debt that should be paid-in-full, eventually.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nuttycom @LukasKorba