Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid example Sapling address in blog post #8

Open
jasondavies opened this issue Oct 29, 2018 · 1 comment
Open

Invalid example Sapling address in blog post #8

jasondavies opened this issue Oct 29, 2018 · 1 comment

Comments

@jasondavies
Copy link

Not sure if this was done on purpose, but in What's New in Sapling, the address zs1z7rejlpsa98s2rrrfkwmaxu53e4ue0ulcrw0h4x5g8jl04tak0d3mm47vdtahatqrlkngh9sly is invalid.

Might be better to show a valid address in case developers use it for testing?

Ref. keybase/client#14364.
@daira
Copy link
Contributor

daira commented May 27, 2019

We should just say in the post that these are not valid addresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasondavies @daira