V8 support

[gsdias]

Can I know when is the v8 being supported by this package? I think READ.ME is outdated as when implementing changes to Global.asax.cs it breaks and FileSystemProvider no longer exists in v8.

[ElijahGlover]

Hi @gsdias

There is no support for v8 yet, two reasons being the IFileSystem interface has changed slightly and new IoC infrastructure changes how custom IFileSystem implementations are registered. There is already work done on this in the v8-dev branch by but no means is it finished. Please feel free to lend a helping hand.

[gsdias]

Is it worth checking how this guys did it? https://our.umbraco.com/packages/collaboration/umbracofilesystemprovidersazure/ And I managed to make it work from this source https://our.umbraco.com/packages/collaboration/umbraco8-simple-aws-s3/ (the upload to s3 flow, not the reading from s3 like virtual provider) I have a developer working in a possible solution already. I just wanted to know what else can I do to support him. Any feedback from someone already into this problem so he could pick up in the right direction.

…

On 2019-05-29 08:44, Elijah Glover wrote: Hi @gsdias [1] There is no support for v8 yet, two reasons being the IFileSystem interface has changed slightly and new IoC infrastructure changes how custom IFileSystem implementations are registered. There is already work done on this in the v8-dev branch by but no means is it finished. Please feel free to lend a helping hand. -- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub [2], or mute the thread [3].

-- Best regards, Goncalo Silva Dias http://www.gsdias.pt - http://h-tracker.com Links: ------ [1] https://github.com/gsdias [2] #34?email_source=notifications&email_token=AANEDUCKO7NV7C74AG4L7QTPXYC2XA5CNFSM4HQAZT3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWOEVBQ#issuecomment-496781958 [3] https://github.com/notifications/unsubscribe-auth/AANEDUBX7TNNIEVENCEZP2LPXYC2XANCNFSM4HQAZT3A

[ElijahGlover]

I haven't had time to update this package to be compatible with v8 as yet. I'm familiar with @JimBobSquarePants Azure provider implementation, it should only take a few hours of full focus.

[gsdias]

Great. What can I do to help you out? Any hint where I should look to get a faster solution and submit a PR?

…

Sent from my iPhone

On May 29, 2019, at 16:41, Elijah Glover ***@***.***> wrote: I haven't had time to update this package to be compatible with v8 as yet. I'm familiar with @JimBobSquarePants Azure provider implementation, it should only take a few hours of full focus. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[snerpton]

Also happy to do some testing when the time comes.

[neilgaietto]

@ElijahGlover
I needed this working for a new project so I got the bare minimum working here: https://github.com/neilgaietto/Umbraco-S3-Provider/tree/v8-dev-working

It sets up the component and composer which are the new features in 8.
Some issues that I did not resolve yet due to lack of time:

1. Hostnames do not work because umbraco breaks when it tries to resolve a full url.
   • I used the Virtual Path Provider found in https://github.com/umbraco-community/UmbracoFileSystemProviders.Azure/tree/develop-umbraco-version-8
2. Bucket prefix was having issue with slashes. Im sure this can be fixed but similar to the full url issue, umbraco does not like your path starting with no slash.
3. I implemented this using app settings instead of parameters. So this version does not have updated instructions.

<add key="BucketFileSystem:Region" value="us-east-1" />
<add key="BucketFileSystem:BucketPrefix" value="media" />
<add key="BucketFileSystem:BucketName" value="{bucketname}" />
<add key="AWSAccessKey" value="" />
<add key="AWSSecretKey" value="" />

I will improve this if I get the time, but I'm hoping you get a chance to look at it too.
Thanks