Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's your stance on collaboration/pull requests? #31

Open
dries007 opened this issue Jan 27, 2025 · 6 comments
Open

What's your stance on collaboration/pull requests? #31

dries007 opened this issue Jan 27, 2025 · 6 comments

Comments

@dries007
Copy link

Hi, nice project, I came here from HN.

What is your stance on accepting contributions from others?
I'm asking because I don't want to spend a bunch of time getting to know this project if I'm just going to end up with a fork :)

The project interests me because I currently have a mess of Python scripts and Google spreadsheets I manually keep up to date to do something quite similar. I've been meaning to clean those up for a while, but they work just well enough that there is always something more urgent to work on.

Of particular interest for me would be working on a data importer, specifically from CSV / XLSX files with configurable format, and some kind of integration with a banking API (PSD2, so it would apply in whole of EU).

No promises though :)

@EnhancedJax
Copy link
Owner

Hi! Contributions are welcomed!

Data import is indeed on the (late) todo list, but would love to get that implemented soon. If you are interested, feel free to contribute! The initial idea was to have the format public and the user can write a script themselves to import, but a built-in importer would help with migrating users! Maybe add a popup that can be triggered from the welcome screen / command palette?

Bank sync is also on the list, but I haven't looked into it enough to design how it would work in the app. But feel free to propose anything and maybe we can work something out!

I just hope my code is readable enough for contributions haha

@lucianosrp
Copy link

This app is very cool and indeed a data importer will definitely be a great addition!

I was also working on something similar on my free time and I would love to see if this app could also adapt the "file-over-app" philosophy where, in principle, you can import/export your data freely without becoming 100% dependent on the app. So an exporter would also be nice to have!

I would love to collaborate on this one too if needed! :)

@EnhancedJax
Copy link
Owner

EnhancedJax commented Jan 28, 2025

This app does adapt that philosophy - it's just a db file! You can locate it using the locate command

@lucianosrp
Copy link

lucianosrp commented Jan 28, 2025

Would you say it would be safe to directly query the DB for import/export? If so, that's great!

@EnhancedJax
Copy link
Owner

Would you say it would be safe to directly query the DB for import/export? If so, that's great!

I'm not sure what you mean't by safe, but yes you can directly query the database with something like sqlalchemy!

@lucianosrp
Copy link

I know some apps that also have a db and don't encourage to directly query it as it might break some internals.
But I understand this is not the case, which is nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants