Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carts E2E Turn off failOnStatusCode #139436

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Carts E2E Turn off failOnStatusCode #139436

merged 3 commits into from
Aug 17, 2023

Conversation

ailZhou
Copy link
Contributor

@ailZhou ailZhou commented Aug 17, 2023

Description

Remove turn off failOnStatusCode to fix cypress redirect issue

Related ticket(s)


How to test

Important updates


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

@codeclimate
Copy link

codeclimate bot commented Aug 17, 2023

Code Climate has analyzed commit b5e6db8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 55.6% (0.0% change).

View more on Code Climate.

@ailZhou ailZhou changed the title Carts E2E Wait Longer Carts E2E Turn off failOnStatusCode Aug 17, 2023
@ailZhou ailZhou marked this pull request as ready for review August 17, 2023 20:26
@BearHanded BearHanded merged commit 3ddf57a into main Aug 17, 2023
14 checks passed
@BearHanded BearHanded deleted the carts-e2e-timeout branch August 17, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants