-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMDCT-4184 cdk-side prepping cdk to import #15044
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3244f05
to
4adc8aa
Compare
6768771
to
76bb00e
Compare
JonHolman
approved these changes
Feb 3, 2025
JonHolman
approved these changes
Feb 3, 2025
benmartin-coforma
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any new red flags compared to what we reviewed before the rebase 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is not to be deployed until we are ready to convert to cdk. For full details of the order of events recommended to preserve our Cloudfront Distribution check out this readme: https://github.com/Enterprise-CMCS/macpro-mdct-seds/blob/cmdct-4184-cdk/import_instructions.md
The idea is that by preserving Cloudfront Distribution we will be able to deploy cdk without requiring any external DNS changes. 🎉
Related ticket
CMDCT-4184
How to test
If you want to you can do the following to test this PR:
Notes
NA
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod