Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input with slotted content (e.g. calcite-button) has a mismatch of component heights when root-font size has changed #7411

Open
2 of 3 tasks
Tracked by #7180
JonnyDawe opened this issue Aug 1, 2023 · 5 comments
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive

Comments

@JonnyDawe
Copy link

Check existing issues

Actual Behavior

calcite-input allows you to use a slotted action next to the text input box.

We have found that if the root font size has been changed e.g. by a user altering their default font-size in chrome for accessibility purposes, then the button inside of the input becomes misaligned. Please see the codepen below for the observed behaviour.

image

Expected Behavior

Ideally the button would stretch to match the height of the input.

Reproduction Sample

https://codepen.io/JDawe/pen/jOQXdRp

Reproduction Steps

See the repro sample. The behaviour can be observed by changing the root font size to a non-standard value (e.g. 24px).

Changing the default font-size typically occurs when a user over-rides the default value inside of their browser.

Reproduction Version

1.4.3

Relevant Info

No response

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

A UI bug. It doesn't effect functionality, but definitely does not look correct.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

N/A

@JonnyDawe JonnyDawe added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Aug 1, 2023
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Aug 1, 2023
@geospatialem
Copy link
Member

e.g. by a user altering their default font-size in chrome for accessibility purposes

@JonnyDawe Can you speak more to the use case for accessibility purposes?

Familiar with users altering their text size via their OS, and via browser zoom in/out - so want to learn more about altering the :root.

@JonnyDawe
Copy link
Author

Hi @geospatialem - altering the :root value in this case was to demonstrate the impact of changing the font size within the browser settings e.g. within chrome (see picture below). This has a similar effect to the css altering the :root value I believe.

As we build a cross-platform app (e.g. using cordova/electron) we have chosen to provide a settings menu which can change the :root font size of the document which is similar to how the browser allows the default value to be altered via a settings menu.

image

@geospatialem
Copy link
Member

Appreciate the context and use case, thanks much @JonnyDawe! While not a workaround for a custom settings action altering the root, users should still be able to interact via OS settings and browser zoom in/out while Calcite works on prioritizing the issue.

@geospatialem geospatialem added a11y Issues related to Accessibility fixes or improvements. design Issues that need design consultation prior to development. labels Aug 1, 2023
@brittneytewks
Copy link

We're going to wait until Design Tokens and reevaluate to see if this is addressed

@brittneytewks brittneytewks added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Aug 17, 2023
@geospatialem geospatialem added the blocked This issue is blocked by another issue. label Aug 18, 2023
@geospatialem
Copy link
Member

geospatialem commented Aug 18, 2023

Blocked by #7180 per comment ☝🏻 .

Will explore the feasibility of the request in the effort of #7180.

@geospatialem geospatialem added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Aug 21, 2023
@brittneytewks brittneytewks removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Dec 12, 2023
@geospatialem geospatialem added design-tokens Issues requiring design tokens. and removed blocked This issue is blocked by another issue. labels Sep 10, 2024
@DitwanP DitwanP added estimate - 5 A few days of work, definitely requires updates to tests. and removed needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Jan 13, 2025
@DitwanP DitwanP added this to the 2025-08-26 - Aug Milestone milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Projects
None yet
Development

No branches or pull requests

4 participants