Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup Title Padding #8

Open
codylawson opened this issue Nov 12, 2015 · 0 comments
Open

Popup Title Padding #8

codylawson opened this issue Nov 12, 2015 · 0 comments
Labels

Comments

@codylawson
Copy link

https://github.com/Esri/dojo-theme-flat/blob/master/STYLUS/esri/dijit/css/Popup.styl#L80
https://github.com/Esri/dojo-theme-flat/blob/master/STYLUS/esri/dijit/css/Popup.styl#L418

In Popup.styl there's a padding rule for .titlePane that is set to auto, which isn't a valid value for padding. This rule is normally just ignored and doesn't seem to cause a problem, unless the stylesheets are run through a minifier like cssmin, in which case the padding rules are merged, i.e.:

padding: 6px;
padding-right: auto;

becomes:

padding: 6px auto 6px;

Is there a reason we're using auto? Should it be inherit or initial instead?

@codylawson codylawson added the bug label Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant