Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11Y | A hidden button element with collapsed state is available in the header section - on activating the button an undefined input field and two unlabeled buttons appears on the top of the page. #335

Open
hilcurtis opened this issue Nov 25, 2020 · 0 comments

Comments

@hilcurtis
Copy link

ID
1847345115

Violation
Provide a valid label for form fields

Module Name
03a Header Menu - Top Row

Description
[Issue]
A hidden button element with collapsed state available in the header section on activating the button an undefined input field and two unlabeled buttons appears on the top of the page.

[User Impact]
When buttons do not explicitly include a label, assistive technologies may incorrectly render the label or provide no label at all to users. When labels are not present or are incorrect, users of assistive technologies may not be able to complete an action.

[Code Reference]

<input class="esri-header-inline-title-input" id="esri-header-inline-title-input" aria-labelledby="esri-header-inline-title-input">

<button class="esri-header-inline-title-action-button esri-header-inline-title-submit-button" aria-labelledby="esri-header-inline-title-action-button"><span class=""><svg...></svg></span></button>

<button class="esri-header-inline-title-action-button esri-header-inline-title-dismiss-button" aria-labelledby="esri-header-inline-title-action-button"><span class=""><svg ..></svg></span></button>	

Note
[Recommendation]
Currently the purpose of this button and these controls is not clear as per the UI.
There are two scenarios for this controls, the first one if it appears on the screen within certain condition it must be visual and should posses a valid programmatic label. In second case while it is hidden from all user, developer should use a display="none" property or otherwise this button should be removed from the DOM.

Developer must provide valid accessible label to input field, right mark icon button and (x)cancel icon button. The aria-labelledby is present on each button element and input element however there is no valid associated text label to their ids.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant