Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't see full list of options in tokenView #11

Open
Smiller193 opened this issue Oct 15, 2018 · 3 comments
Open

Can't see full list of options in tokenView #11

Smiller193 opened this issue Oct 15, 2018 · 3 comments

Comments

@Smiller193
Copy link

For some reason when I display the tokens. I can't see the full list and if i dismiss the keyboard to try and see them the tokens disappear as well.
Also how do you control the size of the imageview, it is way to big in the tokentablecell

@mats-claassen
Copy link
Member

Hi @Smiller193, I saw the issue you opened in Eureka. From what you mentioned there you can do a few things to get this working.

First, when using the TokenTableRow it is important to scroll the row up to make the tableView with options visible. You can do this with the following code (or similar) in onCellHighlightChanged:

.onCellHighlightChanged({ [weak self] (cell, row) in
            if row.isHighlighted {
                DispatchQueue.main.async {
                    self?.tableView.scrollToRow(at: row.indexPath!, at: .top, animated: true)
                }
            }
        })

You also mentioned the imageView is too big. For this you can change the cell that is used for the options. This is explained in the Readme section.
(I am just seeing that that section is copied from the TokenAccessoryRow, but it should be very similar for the table)

@Smiller193
Copy link
Author

Smiller193 commented Oct 18, 2018

@mats-claassen Thank you what i was thinking was just create a table view cell that conforms to the proper protocol (EurekaTokenTableViewCell) and register that instead of just the plain old tableviewcell that is present in the tokenRow?

@mats-claassen
Copy link
Member

I haven't tried that but you could possibly just register that cell in cellSetup yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants