-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the new change off tellraw has a bug #127
Comments
I am not sure that is a bug, the vanilla built in tellraw uses UUID to select entities, so the custom one needs to support this as well |
my tellraw command:
|
Hmm, your code looks correct, maybe verify the |
I tried it, it worked correctly for me, with a very similar command implementation: @Override public boolean onCommand(CommandSender sender, Command command, String label, String[] args){
Player target = Bukkit.getPlayerExact(args[0]);
if(target == null){
try{target = Bukkit.getPlayer(UUID.fromString(args[0]));}
catch(IllegalArgumentException e){}
}
if(target == null || !target.isOnline()){
sender.sendMessage("Offline");
return true;
}
String message = String.join(" ", Arrays.copyOfRange(args, 1, args.length));
try{
Component c = JSONComponentSerializer.json().deserialize(message);
target.sendMessage(c);
}
catch(JsonSyntaxException e){
sender.sendMessage("Invalid");
}
return true;
} |
Maybe I can include this in the base jar, so it does not use |
I found a bug while testing it, certain weapons cause the Component to break, so I am fixing that as well |
I uploaded a new dev version of the plugin here on GitHub (3.9.11), it might fix the issue. It sends the message directly to players now instead of using /tellraw, and it uses Component library functions for the killed entity instead of a selector, since I think the issue was the server lost track of dead entities before the chat messages were sent (since it is in a different thread) |
oks, thx |
Maybe try the latest version v3.9.11, it no longer uses |
It returns unique-id in the message, see image:
The text was updated successfully, but these errors were encountered: