Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose mechanism for enabling/disabling certian optimization rules #3761

Open
universalmind303 opened this issue Feb 3, 2025 · 2 comments
Open
Labels
enhancement New feature or request needs triage

Comments

@universalmind303
Copy link
Contributor

Is your feature request related to a problem?

In some scenarios, some of our heuristic optimization may actually be more costly than naively running the plan as is. As seen here #3759

I'd like a way to enable/disable certain optimizations when executing daft.

Describe the solution you'd like

example usage

# not exactly sure what the most ergonomic api for this would be, but something like this maybe? 
daft.set_planning_config(disable_optimizer_rules=["MaterializeScans"])

Describe alternatives you've considered

No response

Additional Context

No response

Would you like to implement a fix?

No

@universalmind303 universalmind303 added enhancement New feature or request needs triage labels Feb 3, 2025
@aditanase
Copy link

@universalmind303 thanks for reporting. Quick input on the API and format, we can probably take inspiration from the existing engines like pyspark and datafusion:

Turning specific rules on and off might be too granular, you may want to consider higher level knobs.

@universalmind303
Copy link
Contributor Author

@aditanase thanks for the additional context & resources! We'll take a look and see what's the best way we could expose similar settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage
Projects
None yet
Development

No branches or pull requests

2 participants