-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Proxy configuration is ignored by Thrift #8
Comments
Thank you. This saved my day. |
@Chaosspeeder have you managed to make anything with this project? |
It is a lot better to actually handle the setting of the proxy yourself. That way you could let the users of your application configure the proxy itself. I have noticed a lot of applications fail on this relative simple topic. Find more about this here. The same problem can be found in the Python 3.x SDK... |
BattoorCjorn: I disagree. Although it might be useful in some cases to let the user specify different Proxy settings for your application, the system wide settings are there for a reason. In most cases using them should be sufficient to enable access to online services when you are connecting through a proxy. |
I'm not saying no system wide setting should be used, I am saying a fallback should be used if the system wide setting fails, like in corporate environments where they use proxy scripts, ect ...
That means the API does not support proxy overloads, so you would not be able to do this: Just like in Firefox:In this use case if the user fails to load any web page into firefox, he can configure the proxy himself. And that I think is a good design. |
Hi,
in the file THttpClient.cs line 205:
connection.Proxy = null;
the defaul proxy configuration is cleared. If you have set up a proxy in your system settings the proxy server is not used by the Evernote SDK and the connection cannot be established. If you remove this line everything works.
(This bug is also fixed in the newest version of Thrift, so updating Thrift should resolve the issue as well.)
The text was updated successfully, but these errors were encountered: