Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A session doesn't call CompletionHandler during authorization after the user presses the cancel button #7

Open
soniccat opened this issue Nov 16, 2014 · 3 comments

Comments

@soniccat
Copy link

Let's take your sample app for Mac OS. If I press cancel during authorization the completionHandler in authenticateWithWindow method have never been called.

@soniccat soniccat changed the title Session doesn't call CompletionHandler during authorization after user press the cancel button Session doesn't call CompletionHandler during authorization after the user presses the cancel button Nov 16, 2014
@soniccat soniccat changed the title Session doesn't call CompletionHandler during authorization after the user presses the cancel button A session doesn't call CompletionHandler during authorization after the user presses the cancel button Nov 16, 2014
@jorman86
Copy link

i just have the same issue... did you ever solved this problem in anyway?

@jhoughjr
Copy link

With some quick experimentation, I can get it to cal the completion handler.
Though I think the completion handler should have more than just an error, perhaps a result that indicates specifically the user cancelled.

@soniccat
Copy link
Author

I've just uncommented this code in ENOAuthWindowController.m

- (void)cancel:(id)sender
{
    if (self.delegate) {
        [self.delegate oauthViewControllerDidCancel:self];
    }
    self.delegate = nil;
}

and added [self cancel:self]; at the end of doCancel method in the same file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants