Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CANCELED status after cancel() #470

Open
hategan opened this issue May 13, 2024 · 1 comment
Open

CANCELED status after cancel() #470

hategan opened this issue May 13, 2024 · 1 comment

Comments

@hategan
Copy link
Collaborator

hategan commented May 13, 2024

Some LRMs don't have a specific way to mark jobs that are canceled (e.g., PBS). Currently, PBS looks for an exit code of 265 (SIGKILL), but this does not seem to be reliable.

A possible solution would be to mark a job as CANCELED whenever the job is detected as ended if cancel() was previously called. This may hide some corner cases when failures unrelated to cancel() being called happen after the call and which may be relevant in some cases. However, in most normal usage situations, it should properly mark canceled jobs as canceled. We can mitigate the problem with the corner cases by logging the actual exit status from the job.

@hategan
Copy link
Collaborator Author

hategan commented May 13, 2024

@andre-merzky, thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant