Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API route to post application request #572

Open
Niveshkrishna opened this issue Mar 14, 2023 · 4 comments
Open

Add API route to post application request #572

Niveshkrishna opened this issue Mar 14, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested

Comments

@Niveshkrishna
Copy link
Contributor

Create an API route to allow requesting analysis of new applications. Possibly a POST request which accepts package name in the body.

@Niveshkrishna
Copy link
Contributor Author

Niveshkrishna commented Mar 14, 2023

@pnu-s WDYT? I can work on this if OK with you

@codeurimpulsif codeurimpulsif added the question Further information is requested label Mar 14, 2023
@pnu-s
Copy link
Member

pnu-s commented Mar 26, 2023

Thanks @Niveshkrishna for opening this issue.

As far as I can recall (although I don't find any previous issue related to this), the main reason why we do not allow this is to avoid having too many demands, in terms of database size and load.

cc @codeurimpulsif if you can confirm

@codeurimpulsif
Copy link
Contributor

codeurimpulsif commented Mar 27, 2023

Thanks for this issue @Niveshkrishna

And yes as @pnu-s said we don't have this endpoint to avoid too many requests on our API.

But I think it can be a good idea to implement it with an enable/disable toggle in settings (and disabled by default) for people who self-host their own exodus instance. The Exodus Privacy's instance will just not enable it.

@yoshimo
Copy link

yoshimo commented Apr 1, 2023

When the request includes app version , architecture and store, can't you abort early and save resources that would otherwise be spent on downloading the app , unpacking and scanning it or would resources still be a problem?
Applications that are already being scanned at the moment, requests that violate a certain rate limit or where the download failed within the last 4h and versions that were already scanned recently could be cut short right after the attempt to scan them.

The exodus app itself can put more limits on top like not scanning an already scanned app version again when the result is fresh enough to not have changed.

@codeurimpulsif codeurimpulsif added enhancement New feature or request good first issue Good for newcomers labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants