fix: fixed datadog secret key default value (#253)

* fix: changed datadog_key_secret_name default value * fix: fixed typo * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: janli <[email protected]> Co-authored-by: Jay Green-Stevens <[email protected]>
ExpediaGroup · Apr 3, 2024 · 90939aa · 90939aa
1 parent 3e44234
commit 90939aa
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,11 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [7.1.1] - 2024-04-03
+### Fixed
+- Renamed variable from `common_producer_iamroles` to `apiary_common_producer_iamroles` to make the name consistent.
+- Change default value for `datadog_key_secret_name` from `null` to `""`.
+
 ## [7.1.0] - 2024-03-21
 ### Added
 - Added `common_producer_iamroles` to allow roles read-write access to all Apiary managed schemas.

diff --git a/VARIABLES.md b/VARIABLES.md
@@ -24,7 +24,7 @@
 | atlas\_cluster\_name                                      | Name of the Atlas cluster where metastore plugin will send DDL events.  Defaults to `var.instance_name` if not set.                                                                                                  | `string`                 | `""`                                                                                                                                                                                                                                                                                           |    no    |
 | atlas\_kafka\_bootstrap\_servers                          | Kafka instance url.                                                                                                                                                                                                  | `string`                 | `""`                                                                                                                                                                                                                                                                                           |    no    |
 | aws\_region                                               | AWS region.                                                                                                                                                                                                          | `string`                 | n/a                                                                                                                                                                                                                                                                                            |   yes    |
-| common\_producer\_iamroles                                | AWS IAM roles allowed general (not tied to schema) write access to managed Apiary S3 buckets.                                                                                                                        | `list(string)`           | `[]`                                                                                                                                                                                                                                                                                           |    no    |
+| apiary\_common\_producer\_iamroles                                | AWS IAM roles allowed general (not tied to schema) write access to managed Apiary S3 buckets.                                                                                                                        | `list(string)`           | `[]`                                                                                                                                                                                                                                                                                           |    no    |
 | dashboard\_namespace                                      | k8s namespace to deploy grafana dashboard.                                                                                                                                                                           | `string`                 | `"monitoring"`                                                                                                                                                                                                                                                                                 |    no    |
 | db\_apply\_immediately                                    | Specifies whether any cluster modifications are applied immediately, or during the next maintenance window.                                                                                                          | `bool`                   | `false`                                                                                                                                                                                                                                                                                        |    no    |
 | db\_backup\_retention                                     | The number of days to retain backups for the RDS Metastore DB.                                                                                                                                                       | `string`                 | n/a                                                                                                                                                                                                                                                                                            |   yes    |

diff --git a/s3.tf b/s3.tf
@@ -25,7 +25,7 @@ locals {
       client_roles                  = replace(lookup(schema, "client_roles", ""), ",", "\",\"")
       governance_iamroles           = join("\",\"", var.apiary_governance_iamroles)
       consumer_prefix_roles         = lookup(var.apiary_consumer_prefix_iamroles, schema["schema_name"], {})
-      common_producer_iamroles      = join("\",\"", var.common_producer_iamroles)
+      common_producer_iamroles      = join("\",\"", var.apiary_common_producer_iamroles)
     })
   }
 }

diff --git a/variables.tf b/variables.tf
@@ -719,7 +719,7 @@ variable "hms_ro_request_partition_limit" {
 variable "datadog_key_secret_name" {
   description = "Name of the secret containing the DataDog API key. This needs to be created manually in AWS secrets manager. This is only applicable to ECS deployments."
   type        = string
-  default     = null
+  default     = ""
 }
 
 variable "datadog_agent_version" {
@@ -734,8 +734,8 @@ variable "datadog_agent_enabled" {
   default     = false
 }
 
-variable "common_producer_iamroles" {
+variable "apiary_common_producer_iamroles" {
   description = "AWS IAM roles allowed read-write access to managed Apiary S3 buckets."
   type        = list(string)
   default     = []
-}
+}