chore: Added logging to print cluster endpoint used (#140)

* chore: Added logging to print cluster endpoint used Signed-off-by: Bhargav Dodla <[email protected]> --------- Signed-off-by: Bhargav Dodla <[email protected]> Co-authored-by: Bhargav Dodla <[email protected]>
ExpediaGroup · Sep 30, 2024 · 49a9c5f · 49a9c5f
1 parent 2a5cfed
commit 49a9c5f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/go/internal/feast/onlinestore/redisonlinestore.go b/go/internal/feast/onlinestore/redisonlinestore.go
@@ -21,6 +21,7 @@ import (
 
 	"github.com/feast-dev/feast/go/protos/feast/serving"
 	"github.com/feast-dev/feast/go/protos/feast/types"
+	"github.com/rs/zerolog/log"
 	redistrace "gopkg.in/DataDog/dd-trace-go.v1/contrib/redis/go-redis.v9"
 )
 
@@ -112,19 +113,21 @@ func NewRedisOnlineStore(project string, config *registry.RepoConfig, onlineStor
 	}
 
 	if redisStoreType == redisNode {
+		log.Info().Msgf("Using Redis: %s", address[0])
 		store.client = redis.NewClient(&redis.Options{
 			Addr:      address[0],
-			Password:  password, // No password set
+			Password:  password,
 			DB:        db,
 			TLSConfig: tlsConfig,
 		})
 		if strings.ToLower(os.Getenv("ENABLE_DATADOG_REDIS_TRACING")) == "true" {
 			redistrace.WrapClient(store.client, redistrace.WithServiceName(redisTraceServiceName))
 		}
 	} else if redisStoreType == redisCluster {
+		log.Info().Msgf("Using Redis Cluster: %s", address)
 		store.clusterClient = redis.NewClusterClient(&redis.ClusterOptions{
-			Addrs:     []string{address[0]},
-			Password:  password, // No password set
+			Addrs:     address,
+			Password:  password,
 			TLSConfig: tlsConfig,
 			ReadOnly:  true,
 		})

diff --git a/go/internal/feast/registry/http.go b/go/internal/feast/registry/http.go
@@ -34,6 +34,7 @@ func NewHttpRegistryStore(config *RegistryConfig, project string) (*HttpRegistry
 		TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
 		IdleConnTimeout: 60 * time.Second,
 	}
+	log.Info().Msgf("Using Feature Registry: %s", config.Path)
 
 	hrs := &HttpRegistryStore{
 		project:  project,

diff --git a/sdk/python/feast/infra/online_stores/redis.py b/sdk/python/feast/infra/online_stores/redis.py
@@ -223,6 +223,7 @@ def _get_client(self, online_store_config: RedisOnlineStoreConfig):
                 online_store_config.connection_string
             )
             if online_store_config.redis_type == RedisType.redis_cluster:
+                logger.info(f"Using Redis Cluster: {startup_nodes}")
                 kwargs["startup_nodes"] = [
                     ClusterNode(**node) for node in startup_nodes
                 ]
@@ -233,10 +234,12 @@ def _get_client(self, online_store_config: RedisOnlineStoreConfig):
                 for item in startup_nodes:
                     sentinel_hosts.append((item["host"], int(item["port"])))
 
+                logger.info(f"Using Redis Sentinel: {sentinel_hosts}")
                 sentinel = Sentinel(sentinel_hosts, **kwargs)
                 master = sentinel.master_for(online_store_config.sentinel_master)
                 self._client = master
             else:
+                logger.info(f"Using Redis: {startup_nodes[0]}")
                 kwargs["host"] = startup_nodes[0]["host"]
                 kwargs["port"] = startup_nodes[0]["port"]
                 self._client = Redis(**kwargs)