Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEDIUM: [Tracking] Implement more E2E tests and add new metrics #30265

Open
8 tasks
mountiny opened this issue Oct 24, 2023 · 62 comments
Open
8 tasks

MEDIUM: [Tracking] Implement more E2E tests and add new metrics #30265

mountiny opened this issue Oct 24, 2023 · 62 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Monthly KSv2 Not a priority Planning Changes still in the thought process Reviewing Has a PR in review

Comments

@mountiny
Copy link
Contributor

mountiny commented Oct 24, 2023

The E2E tests are now set up and working again, lets expand on their options and add more flows and metrics:

  • chat switching/opening for the first time
  • typing
  • scrolling chat messages
  • number of renders when we open chat (it should be 1-2)
  • searching
  • signing in
  • scrolling list of chats
  • onyx tests

@Szymon20000 @hannojg

Issue OwnerCurrent Issue Owner: @kirillzyusko
@mountiny mountiny added the Planning Changes still in the thought process label Oct 24, 2023
@mountiny mountiny self-assigned this Oct 24, 2023
@hannojg
Copy link
Contributor

hannojg commented Oct 24, 2023

👋

@hannojg
Copy link
Contributor

hannojg commented Oct 25, 2023

@perunt

@perunt
Copy link
Contributor

perunt commented Oct 25, 2023

👋

@mountiny
Copy link
Contributor Author

Also Assigning @AndrewGable as he will most likely help us too 🤝 feel free to unassign if you prefer

@hannojg
Copy link
Contributor

hannojg commented Oct 27, 2023

Update:

There was again a false positive on the e2e test runs. Added this PR trying to minimise those errors:

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 labels Oct 27, 2023
@hannojg
Copy link
Contributor

hannojg commented Oct 27, 2023

Update:

First PR for adding tests for typing is up:

Copy link

melvin-bot bot commented Nov 7, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@mountiny
Copy link
Contributor Author

mountiny commented Nov 8, 2023

Lies, it was a different pr causing the issue

@perunt perunt mentioned this issue Nov 16, 2023
58 tasks
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Dec 1, 2023
Copy link

melvin-bot bot commented Dec 1, 2023

This issue has not been updated in over 15 days. @AndrewGable, @hannojg, @mountiny, @perunt eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mountiny
Copy link
Contributor Author

mountiny commented Dec 4, 2023

@hannojg @perunt how is it going?

@hannojg
Copy link
Contributor

hannojg commented Dec 4, 2023

  • The typing test is implemented and merged!
  • For Chat switching we have a PR which should be done latest by end of this week: E2E chat opening #30634
  • For the remaining tests we will put again more focus on that to finish it off soon!

(Note: we are internally working on a system to make the e2e tests even better, more news on that soon! ™️ )

@mountiny
Copy link
Contributor Author

mountiny commented Dec 4, 2023

Thanks!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Dec 5, 2023
@dangrous dangrous self-assigned this Dec 15, 2023
@dangrous
Copy link
Contributor

adding myself here for reviewing the chat switching one!

@hannojg
Copy link
Contributor

hannojg commented Dec 19, 2023

Chat switching is merged 🎊 !

@perunt I think we can add "number of renders when we open chat (it should be 1-2)" to the same test as second metric?

Also next up would be the search page test!

@kirillzyusko
Copy link
Contributor

@dangrous I think we are currently (still) trying to fix e2e tests. And only after that we can start to write new e2e tests 👀

@melvin-bot melvin-bot bot added the Overdue label Aug 29, 2024
@dangrous
Copy link
Contributor

how are we looking?

@melvin-bot melvin-bot bot removed the Overdue label Aug 30, 2024
@kirillzyusko
Copy link
Contributor

@dangrous Still fixing e2e tests 😅 Recent RN 0.75 broke them 😔

@hannojg
Copy link
Contributor

hannojg commented Sep 24, 2024

Okay, so the tests are stable again, and we are collecting additional metrics.
Now we'd like to add more e2e performance regression tests. What other flows do you think are important to cover?
I feel like we currently don't really cover any money request flows?

We will add other tests like chat scrolling etc as mentioned in the issue's description soon!

@mountiny
Copy link
Contributor Author

Yes, create money request flow - a manual would be good. Not sure if its possible to test the one with a scan, you might have to upload a file

@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2024
@dangrous
Copy link
Contributor

dangrous commented Nov 1, 2024

How are things going here?

@melvin-bot melvin-bot bot removed the Overdue label Nov 1, 2024
@hannojg
Copy link
Contributor

hannojg commented Nov 4, 2024

cc @kirillzyusko is working on that (please assign him as well). We've overhauled the e2e pipeline to be more robust. We have to fix one failing test, but are otherwise ready to write some more e2e tests this week (finally!!)

@dangrous
Copy link
Contributor

dangrous commented Nov 4, 2024

awesome!

@kirillzyusko
Copy link
Contributor

Yes, I should get some time to work on new e2e tests this week!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Nov 19, 2024
@mountiny mountiny self-assigned this Nov 22, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

This issue has not been updated in over 15 days. @dangrous, @hannojg, @kirillzyusko, @mountiny, @perunt eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@hannojg
Copy link
Contributor

hannojg commented Dec 30, 2024

We are actively working on extending the e2e test suite. Current next PR we're working on is:

@melvin-bot melvin-bot bot closed this as completed Feb 10, 2025
Copy link

melvin-bot bot commented Feb 10, 2025

@dangrous, @hannojg, @kirillzyusko, @mountiny, @perunt, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@perunt
Copy link
Contributor

perunt commented Feb 10, 2025

It's alive. There are two new tests on the way:
#52751
#54625

@dangrous
Copy link
Contributor

yep, reopening. chill, melvin

@dangrous dangrous reopened this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Monthly KSv2 Not a priority Planning Changes still in the thought process Reviewing Has a PR in review
Projects
Status: Done
Development

No branches or pull requests

8 participants