[HOLD Onyx PR 588][$100] Migrate AuthScreens to useOnyx

[roryabraham]

Currently Held on Expensify/react-native-onyx#588

Coming from https://expensify.slack.com/archives/C01GTK53T8Q/p1725973460005309?thread_ts=1725905735.105989&cid=C01GTK53T8Q

Migrate src/libs/Navigation/AppNavigator/AuthScreens.tsx to use useOnyx instead of withOnyx.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021834281376353079480
• Upwork Job ID: 1834281376353079480
• Last Price Increase: 2024-09-12
• Automatic offers:
• c3024 | Reviewer | 103949192
• BhuvaneshPatil | Contributor | 103949194

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021834281376353079480

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[melvin-bot]

Upwork job price has been updated to $100

[BhuvaneshPatil]

Dibs

[BhuvaneshPatil]

Do we need to submit proposal?

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Migrate AuthScreens to useOnyx

What is the root cause of that problem?

This is an improvement

What changes do you think we should make in order to solve the problem?

Remove the withOnyx here and use useOnyx hook. Also remove the type props here

const [session] = useOnyx(ONYXKEYS.SESSION);
const [lastOpenedPublicRoomID] = useOnyx(ONYXKEYS.LAST_OPENED_PUBLIC_ROOM_ID);
const [initialLastUpdateIDAppliedToClient] = useOnyx(ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT);

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Line 570 in 7748eff

export default withOnyx<AuthScreensProps, AuthScreensProps>({

What alternative solutions did you explore? (Optional)

[zanyrenney]

@roryabraham @c3024 want to take a look at the proposals here please?

[c3024]

It is a simple enough task. I think it is fine to give it to @BhuvaneshPatil if he has not been assigned any other useOnyx migration. Otherwise @nkdengineer can be assigned.

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Current assignee @roryabraham is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[BhuvaneshPatil]

Thanks @c3024 ,
I am not assigned to any migration task

[roryabraham]

Both @BhuvaneshPatil and @nkdengineer are now assigned to one other migration each, so I'm going to treat this one on a first-come-first-serve and give it to @BhuvaneshPatil

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @BhuvaneshPatil 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[BhuvaneshPatil]

@c3024 Raised the PR

• chore: migrate AuthScreens from withOnyx to useOnyx #49185

[melvin-bot]

@BhuvaneshPatil, @roryabraham, @zanyrenney, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[roryabraham]

PR review in progress

[melvin-bot]

@BhuvaneshPatil, @roryabraham, @zanyrenney, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[roryabraham]

Headed on parental leave. Between @c3024 @BhuvaneshPatil and @blazejkustra this issue should be pretty well-handled. But going to pull in another Expensify engineer to help out with the final review. @MonilBhavsar choosing you at random, hope you don't mind 🙂

[MonilBhavsar]

Happy parental leave, Rory! I can take over this 🫡

[parasharrajat]

is this issue completed?

[MonilBhavsar]

Not yet, it's on HOLD as per this #49103 (comment)

[zanyrenney]

Issue is still on hold, per the comment above!

[zanyrenney]

Issue is on HOLD

[zanyrenney]

@MonilBhavsar i am going to make this weekly for now. If this gets taken off hold, please feel free to make DAILY.

[fabioh8010]

Just a note here: We have this Onyx PR that will fix the issues with infinite loading noticed in this migration, but I noticed an additional problem that is not covered by my PR and it happens by just migrating the component to useOnyx. I will cross-post the message I left in the PR.

❗️You will notice that after second login on Web/mWeb, user is redirected to settings page instead of home. Please have in mind that this issue is not related to these fixes, but instead one more fix that would be necessary to be made on E/App when migrating AuthScreens.tsx to useOnyx.❗️

[MonilBhavsar]

Thanks for the heads up @fabioh8010! 👍

[zanyrenney]

@MonilBhavsar @fabioh8010 @BhuvaneshPatil please remember to keep the issue updated with progress, there hasn't been any update here in awhile! Thanks!