Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[not here] Expense - Not here page is displayed when opening a third expense in a report #55429

Open
1 of 8 tasks
lanitochka17 opened this issue Jan 17, 2025 · 13 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Overdue

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 17, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.87-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team
Component: Money Requests

Action Performed:

  1. Log into new dot with 2 different accounts on different tabs (User A and B)
  2. As user A submit two manual expenses to user B
  3. Navigate to the tab where you are logged in as user B and open the combined expense report (Keep the report open)
  4. As user A submit another expense to user B
  5. As user B open the third expense

Expected Result:

The expense report is opened

Actual Result:

"Hmm... it's not here" page is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6717041_1737141103299.2025-01-17_22_02_24.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @yuwenmemon
@lanitochka17 lanitochka17 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jan 17, 2025
Copy link

melvin-bot bot commented Jan 17, 2025

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Overdue label Jan 20, 2025
@Kalydosos
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Not here page is displayed when opening a third expense in a report

What is the root cause of that problem?

The pusher does not send the "childReportID" attribute when one more expense is sent from userA to userB

What changes do you think we should make in order to solve the problem?

The issue requires a BE fix. The pusher should send the "childReportID" attribute in the reportAction when one more expense is sent from userA to userB. That attribute value is sent by userA requestMoney request as transactionThreadReportID

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Given a money request action
When calling ROUTES.REPORT_WITH_ID.getRoute for the action childReportID
Then the result must not be "r/-1"

What alternative solutions did you explore? (Optional)

None

Copy link

melvin-bot bot commented Jan 21, 2025

@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@trjExpensify
Copy link
Contributor

I can repro this. @mountiny @luacmartins do you know if there's a reason for this?

The issue requires a BE fix. The pusher should send the "childReportID" attribute in the reportAction when one more expense is sent from userA to userB. That attribute value is sent by userA requestMoney request as transactionThreadReportID

2025-01-22_14-01-09.mp4

@luacmartins
Copy link
Contributor

@yuwenmemon any ideas if work done for https://github.com/Expensify/Expensify/issues/346748 could have caused this issue?

@melvin-bot melvin-bot bot added the Overdue label Jan 27, 2025
@trjExpensify
Copy link
Contributor

Bump @yuwenmemon! :)

@melvin-bot melvin-bot bot removed the Overdue label Jan 27, 2025
@yuwenmemon
Copy link
Contributor

Hmmm... Certainly possible although we haven't done anything new for that recently (but I see this is also happening in production).

I'll have a look!

@yuwenmemon yuwenmemon self-assigned this Jan 28, 2025
@melvin-bot melvin-bot bot added the Overdue label Jan 30, 2025
@trjExpensify
Copy link
Contributor

Lavely, thanks Yuwen!

@melvin-bot melvin-bot bot removed the Overdue label Jan 31, 2025
Copy link

melvin-bot bot commented Jan 31, 2025

@yuwenmemon @trjExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Feb 3, 2025
Copy link

melvin-bot bot commented Feb 3, 2025

@yuwenmemon, @trjExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@muttmuure muttmuure moved this to CRITICAL in [#whatsnext] #quality Feb 3, 2025
Copy link

melvin-bot bot commented Feb 5, 2025

@yuwenmemon, @trjExpensify Huh... This is 4 days overdue. Who can take care of this?

@muttmuure muttmuure added Hot Pick Ready for an engineer to pick up and run with and removed Hot Pick Ready for an engineer to pick up and run with labels Feb 5, 2025
@yuwenmemon
Copy link
Contributor

I had some External Commit: NSQS things come up - but should be able to look soon.

@melvin-bot melvin-bot bot removed the Overdue label Feb 7, 2025
Copy link

melvin-bot bot commented Feb 10, 2025

@yuwenmemon, @trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Feb 10, 2025
@mallenexpensify mallenexpensify changed the title Expense - Not here page is displayed when opening a third expense in a report [not here] Expense - Not here page is displayed when opening a third expense in a report Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Overdue
Projects
Status: CRITICAL
Development

No branches or pull requests

6 participants