Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2025-01-23 #55657

Closed
github-actions bot opened this issue Jan 23, 2025 · 24 comments
Closed

Deploy Checklist: New Expensify 2025-01-23 #55657

github-actions bot opened this issue Jan 23, 2025 · 24 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025

Release Version: 9.0.89-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 23, 2025
@mountiny
Copy link
Contributor

desktop build was successful so checking #55282 off

@francoisl
Copy link
Contributor

Demoting #55672 as it's behind a beta

@jasperhuangg
Copy link
Contributor

Demoting #55690

@mvtglobally
Copy link

mvtglobally commented Jan 24, 2025

Regression is at 60% TCs completed. High number of PRs still need testing

Blockers
#55660
#55661
#55662
#55674
#55675
#55678
#55681
#55690

PRs
Checking off #54306 (comment)

@Beamanator
Copy link
Contributor

#55678 confirmed nab

@izarutskaya
Copy link

Regression is at 92% TCs completed.

#54278 - failing with #54278 (comment)
#54534 - failing with #54534 (comment)
#54798 - pending validation on all environments
#55285 - #55285 (comment)
#55443 - failing on Android and iOS app with original issue #55443 (comment)

DB:
#55660
#55661
#55662
#55674
#55675
#55678
#55681
#55693
#55707

@Beamanator
Copy link
Contributor

#55707 marked NAB 👍

@grgia
Copy link
Contributor

grgia commented Jan 24, 2025

Cannot reproduce #55733 so I closed it

@joekaufmanexpensify
Copy link
Contributor

checked off #55387

@joekaufmanexpensify
Copy link
Contributor

checked off #55561

@mvtglobally
Copy link

Regression is at 99% TCs completed.

#54278 - failing with #55666. This seems a big one, but its repro in PROD. Let us know if we are ok to check it off.
#54534 - We had 2 issues #55733 & #55673. Both are closed, so checking off
#54755 - #55744. Repro in PROD checking off
#54798 - pending validation on IOS
#55095 - Pending validation on Web/Desktop/IOS
#55264 - Pending validation on Native apps
#55442 - low issue found, checking off
#55443 - failing on Android and iOS app with original issue #55443 (comment)
#55474 - Pending validation on Web/Desktop/Native Apps
#55494 - Pending validation on mWeb
#55503 - Pending validation on Android
#55592 - Pending validation on Android
#55598 - Is failing with KI #55040
#55712 - Checking CP
#55716 - Checking CP

DB:
#55660
#55661
#55674
#55675
#55681
#55693
#55715

@isagoico
Copy link

isagoico commented Jan 24, 2025

Highlighting this issue as it's failing a Critical TC - #55682. It was intermittent but several testers were ablet to reproduce and some were able to reproduce in Prod. Labeled it as Hourly.

@mvtglobally
Copy link

Regression is completed

#54278 - failing with #55666. This seems a big one, but its repro in PROD. Let us know if we are ok to check it off.
#54798 - pending validation on IOS
#55095 - Pending validation on Web/Desktop/IOS
#55264 - Pending validation on Android
#55443 - failing on Android and iOS app with original issue #55443 (comment)
#55474 - Pending validation on Web/Desktop/Native Apps
#55494 - Pending validation on mWeb
#55503 - Pending validation on Android
#55592 - Pending validation on Android
#55716 - Checking CP

DB:
#55660
#55661
#55681
#55693
#55715

@Beamanator
Copy link
Contributor

#55660 checked off as fixed by #55712

@Beamanator
Copy link
Contributor

#55682 was marked nAB

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jan 27, 2025
@mountiny
Copy link
Contributor

Checked #55443 off
checked #55693 off

@mountiny
Copy link
Contributor

Checked #55716 off

@amyevans
Copy link
Contributor

Checked off #55780 after CP

@yuwenmemon
Copy link
Contributor

Checking off #54798 as it's still on a beta.

@yuwenmemon
Copy link
Contributor

Checking off #54278 as per the conversation with @srikarparsi here

@mvtglobally
Copy link

@yuwenmemon Unchecked PRs

#55494 (comment)
#55474 - still pending validation. It would be great if you can also cross check internally with real PayPal receipts.
#55592 We are unable to access Public room on Android Hybrid app as it leads to mWeb. I believe its ok to check it off. Pls confirm

@yuwenmemon
Copy link
Contributor

For #55494 (comment) I won't consider that last part a blocker since it's pretty minor. I'll make sure to comment on the original issue that the author will need to make a follow-up to fix android in order to get paid.

@yuwenmemon
Copy link
Contributor

@yuwenmemon
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests