[$250] Trip summary not displayed for thread replies

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.92-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shubham1206agra
Slack conversation (hyperlinked to channel name): travel

Action Performed:

1. Go to a trip room
2. Write a test message in the room
3. Click on reply in thread to open thread

Expected Result:

It should look like a normal thread

Actual Result:

Empty trip summary appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021885343111802950570
• Upwork Job ID: 1885343111802950570
• Last Price Increase: 2025-01-31

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @blazejkustra

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[blazejkustra]

I'm Błażej Kustra from SWM, and I'm commenting for assignment!

[sumo-slonik]

Hi, I'll be helping out @blazejkustra here.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021885343111802950570

[melvin-bot]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[blimpich]

Assigned to myself so that there is an Expensify CME for this who is focused on travel.

Removed Help Wanted since there are engineers already working on this.

[shubham1206agra]

Waiting for @sumo-slonik to raise a PR.

[sumo-slonik]

@shubham1206agra Could you help me reproduce the bug?
I see the thread seems normal to me, both for the hotel and the flight.

[shubham1206agra]

@sumo-slonik Go inside a comment thread from here.

[sumo-slonik]

@shubham1206agra could you include a video of you entering the trip room and adding a comment in addition to the screenshot?

[shubham1206agra]

@sumo-slonik Here you go

Screen.Recording.2025-02-05.at.8.04.13.PM.mov

[sumo-slonik]

thanks :D

[sumo-slonik]

I managed to reproduce, without recording I did not understand the flow

[sumo-slonik]

Hi @shubham1206agra @blimpich, could you confirm if the thread is working as it should in the attached video?

Screen.Recording.2025-02-07.at.12.29.25.mov

[shubham1206agra]

@sumo-slonik Chat header looks wrong.

Also, I don't think we need trip preview in the thread. But I will let @Expensify/design decide on this.

[shawnborton]

Hmm I am not following, do you mind rephrasing? Maybe it would be helpful to show the parent view of each step down into the thread history as well?

[melvin-bot]

@slafortune, @blimpich, @blazejkustra, @shubham1206agra, @sumo-slonik Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[blazejkustra]

I'll take over as @sumo-slonik is OOO this week. I'm going leave an update later today, so stay tuned 😄

[dannymcclain]

Maybe it would be helpful to show the parent view of each step down into the thread history as well?

Yeah this would be helpful for me too. I'm having trouble following the different cases here so it's hard for me to know what the expected behavior should be.

[blazejkustra]

The issue we are trying to fix is that currently nested threads aren't displayed properly for trip rooms:

• Empty trip summary is shown to the user
• There is no parent message displayed which is usually a thing we do in other type of rooms

before.mov

My suggested approach is to display both: trip summary and the parent message of a thread, like in this video below:

fix.mov

Let me know if it looks good to you both @dannymcclain & @shawnborton 👀

[dannymcclain]

Ahhh I see! So in that case, I think your second thread would just have THREAD START as the parent message and nothing else. You can see how in the nested expense thread we don't also include the expense summary, so I don't see why the trip one would behave any different.

[shawnborton]

Yeah, I think I agree with Danny. Basically this should have THREAD START as the parent thread:

[blazejkustra]

Makes sense! PR is ready for review @shubham1206agra 😄

www.mov

[dannymcclain]

Looks good—any idea why the title of all these threads is Chat report instead of the actual title?

[blazejkustra]

Good question @dannymcclain, this looks weird. I briefly looked through the code and we use the report name from the backend. Could you have a look @rlinoz / @stitesExpensify?

       if (isTripRoom(report)) {
            return report?.reportName ?? '';
        }

[blazejkustra]

This doesn't mean we have to block the above PR, as this seems unrelated. cc @shubham1206agra

[rlinoz]

Every thread has the report name set to Chat Report so the code is not wrong, but we will have to figure out when a thread is a thread inside a tripRoom and when we are looking at the tripRoom as a thread, as in it is a thread from the policy expense chat.

[rlinoz]

Maybe just update it to

        if (isTripRoom(report) && report?.reportName !== CONST.REPORT.DEFAULT_REPORT_NAME) {
            return report?.reportName ?? '';
        }

[blimpich]

Maybe just update it to

        if (isTripRoom(report) && report?.reportName !== CONST.REPORT.DEFAULT_REPORT_NAME) {
            return report?.reportName ?? '';
        }

I think this should work, @blazejkustra if you try this do you see any issues?