[$250] Can't Hold card expenses

[garrettmknight]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: N/A
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation (hyperlinked to channel name): #expense

Preconditions:

• Assign a card to the submitter via domain control/Classic that's importing transactions
• Enable approvals

Action Performed:

1. As a submitter, submit a card transaction
2. As an approver, open the details menu of the expense

Expected Result:

The approver should see the option to Hold an expense

Actual Result:

The approver doesn't see the option to Hold an expnese

Workaround:

No workaround.

Platforms:

Which of our officially supported platforms is this issue occurring on?
All

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021887314499991264995
• Upwork Job ID: 1887314499991264995
• Last Price Increase: 2025-02-13

Issue Owner

Current Issue Owner: @suneox

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021887314499991264995

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[garrettmknight]

@dylanexpensify Gonna start it as External since this might actually be a FE issue.

[NJ-2020]

@garrettmknight Actually this a BE issue
We will show the hold option if it's match these 3 conditions

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 358 to 361 in a8daefb

	textTranslateKey: 'iou.hold',
	icon: Expensicons.Stopwatch,
	shouldShow: ({type, moneyRequestAction, areHoldRequirementsMet}) =>
	type === CONST.CONTEXT_MENU_TYPES.REPORT_ACTION && areHoldRequirementsMet && canHoldUnholdReportAction(moneyRequestAction).canHoldRequest,

All the conditions were matched but only the last one is returning false which is canHoldUnholdReportAction(moneyRequestAction).canHoldRequest

Inside canHoldUnholdReportAction function we will return false if the action name is not IOU and if the IOUReportID is not exist

App/src/libs/ReportUtils.ts

Lines 3639 to 3642 in a8daefb

	function canHoldUnholdReportAction(reportAction: OnyxInputOrEntry<ReportAction>): {canHoldRequest: boolean; canUnholdRequest: boolean} {
	if (!isMoneyRequestAction(reportAction)) {
	return {canHoldRequest: false, canUnholdRequest: false};
	}

App/src/libs/ReportUtils.ts

Lines 3644 to 3649 in a8daefb

	const moneyRequestReportID = getOriginalMessage(reportAction)?.IOUReportID;
	const moneyRequestReport = getReportOrDraftReport(String(moneyRequestReportID));
	if (!moneyRequestReportID || !moneyRequestReport) {
	return {canHoldRequest: false, canUnholdRequest: false};
	}

App/src/libs/ReportActionsUtils.ts

Lines 161 to 163 in a8daefb

	function isMoneyRequestAction(reportAction: OnyxInputOrEntry<ReportAction>): reportAction is ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.IOU> {
	return isActionOfType(reportAction, CONST.REPORT.ACTIONS.TYPE.IOU);
	}

But since the BE is returning the action name as PREVIEW instead of IOU and some properties regarding to IOU is not exists like IOUReportID, so the above function canHoldUnholdReportAction will return false

---

But I think maybe we can also solve this by using workaround solution
Right here instead of checking the action name only, we can check if the childType is equal to expense

App/src/libs/ReportActionsUtils.ts

Lines 161 to 163 in a8daefb

	function isMoneyRequestAction(reportAction: OnyxInputOrEntry<ReportAction>): reportAction is ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.IOU> {
	return isActionOfType(reportAction, CONST.REPORT.ACTIONS.TYPE.IOU);
	}

And instead of IOUReportID we can check if the action name is preview then we will use the report id

and so on..

But yeah this workaround solution may work but maybe it cause any error/bugs in the future

[dylanexpensify]

@suneox can we get a review on @NJ-2020's proposal? 🙇‍♂

[suneox]

@suneox can we get a review on @NJ-2020's proposal? 🙇‍♂

Yes i'll review this comment within few hours

[suneox]

We have a logic check for the iou.hold menu that depends on moneyRequestAction, with a lot of logic in the canHoldUnholdReportAction function. However, the childReport only loads when we open the details from reportAction, so I think we have a limitation on this case before open report detail and need the internal team to take a look on this issue.
We are still looking solution on this one

[DylanDylann]

@suneox Could you reproduce this issue?

[NJ-2020]

@suneox The issue is still reproducible even we opened the expense in details view

Screen.Recording.2025-02-08.at.18.56.59.mov

[suneox]

@suneox Could you reproduce this issue?

Still reproducible on the latest main branch for both single and multiple money request cases.

Screen.Recording.2025-02-09.at.22.30.14.mov

@suneox The issue is still reproducible even we opened the expense in details view

The issue is no longer reproducible after opening the details.

Screen.Recording.2025-02-09.at.22.32.31.mov

[NJ-2020]

@suneox

The issue is no longer reproducible after opening the details.

Ohh, your steps are different than mine, I followed the steps mentioned in the OP, see in this video

Screen.Recording.2025-02-10.at.17.21.20.1.mov

[suneox]

@suneox

The issue is no longer reproducible after opening the details.

Ohh, your steps are different than mine, I followed the steps mentioned in the OP, see in this video

Screen.Recording.2025-02-10.at.17.21.20.1.mov

The hold option does not appear in this case due to the condition checking transaction.reimbursable

@NJ-2020 If you have a solution, could you please update proposal following the template?

[DylanDylann]

@suneox I am asking @puneetlath about this bug here. I think we need to wait for him to reply before moving forward

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸