Group - Hover profile of group 6+ members, the tooltip displays five members without ellipsis

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.95-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Issue reported by: Applause Internal Team
Device used: Win 11/Chrome
App Component: Chat Report View

Action Performed:

1. Open https://staging.new.expensify.com/
2. Click on group chat having 6+ members
3. Hover over profile

Expected Result:

Hover over profile, the tooltip should display five members and ellipsis

Actual Result:

Hover over profile, the tooltip is displaying five members as this group only having 5 members

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6736754_1738976735798.Recording__900.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Shahidullah-Muffakir]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-08 19:21:33 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

we are only showing 5 users names in the group chat when user hovers over the avatar, but we are not adding the ellipsis for the rest of the names

What is the root cause of that problem?

1. we are not considering ellipsis here if the the length is more than 5:

   App/src/libs/ReportUtils.ts

   Line 2584 in 631006e

   participantAccountIDs = participantAccountIDs.slice(0, 5);

What changes do you think we should make in order to solve the problem?

1. we can create a variable like

let shouldUseEllipsis = false;

2. and here when the length is more than 5 then show ellipsis:
   

   App/src/libs/ReportUtils.ts

   Lines 2583 to 2585 in 631006e

   	if (shouldApplyLimit) {
   	participantAccountIDs = participantAccountIDs.slice(0, 5);
   	}

   
   as:

    if (shouldApplyLimit) {
        if(participantAccountIDs.length > 5) {
            shouldUseEllipsis = true;
        }
        participantAccountIDs = participantAccountIDs.slice(0, 5);
    }

3. add the ... in the end here:
   

   App/src/libs/ReportUtils.ts

   Lines 2588 to 2597 in 631006e

   	if (isMultipleParticipantReport) {
   	return participantAccountIDs
   	.map(
   	(participantAccountID, index) =>
   	getDisplayNameForParticipant({accountID: participantAccountID, shouldUseShortForm: isMultipleParticipantReport}) || formatPhoneNumber(participants?.[index]?.login ?? ''),
   	)
   	.sort((first, second) => localeCompare(first ?? '', second ?? ''))
   	.filter(Boolean)
   	.join(', ');
   	}

   
   as:

               .join(', ') + (shouldUseEllipsis ? '...' : '');

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

If we want the ellipsis to be added only in the HeaderView, then:

1. we can pass a new param like showEllipsis to the getIcons here:
   

   App/src/pages/home/HeaderView.tsx

   Line 195 in 631006e

   const icons = getIcons(reportHeaderData, personalDetails, null, '', -1, policy, invoiceReceiverPolicy);

2. Then pass it here to the getGroupChatName:
   

   App/src/libs/ReportUtils.ts

   Lines 2764 to 2772 in 631006e

   	if (isGroupChat(report)) {
   	const groupChatIcon = {
   	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
   	source: report.avatarUrl || getDefaultGroupAvatar(report.reportID),
   	id: -1,
   	type: CONST.ICON_TYPE_AVATAR,
   	name: getGroupChatName(undefined, true, report),
   	};
   	return [groupChatIcon];

3. and then only add the ellipsis based on this new param

Screen.Recording.2025-02-09.at.12.39.14.AM.mov

The alternative approach will work if we don't want the ellipsis in the details page as shown:

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Group - Hover profile of group 6+ members, the tooltip displays five members without ellipsis

What is the root cause of that problem?

If the report has multiple participants we're get the first 5 first participants, then concat them in a single report name

App/src/libs/ReportUtils.ts

Lines 2583 to 2597 in 631006e

	if (shouldApplyLimit) {
	participantAccountIDs = participantAccountIDs.slice(0, 5);
	}
	const isMultipleParticipantReport = participantAccountIDs.length > 1;
	if (isMultipleParticipantReport) {
	return participantAccountIDs
	.map(
	(participantAccountID, index) =>
	getDisplayNameForParticipant({accountID: participantAccountID, shouldUseShortForm: isMultipleParticipantReport}) || formatPhoneNumber(participants?.[index]?.login ?? ''),
	)
	.sort((first, second) => localeCompare(first ?? '', second ?? ''))
	.filter(Boolean)
	.join(', ');
	}

What changes do you think we should make in order to solve the problem?

We have 2 issues here:

1. The group name doesn't have the ellipsis style
2. If the participant's display name/login name is too long, then when the user opens the group name settings, this may cause an error without any changes as we limit the maximum name length to 100 characters

We should truncate the group name in

App/src/libs/ReportUtils.ts

Line 2596 in 631006e

.join(', ');

.join(', ').slice(0, 97) + '...'

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Test the getGroupChatName function to verify the output length is less than or equal 100 characters

What alternative solutions did you explore? (Optional)

We can also add the flag to enable/disable this feature in the specific page

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.