Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building on iOS with the new architecture enabled fails. #326

Closed
psquizzle opened this issue Apr 22, 2024 · 6 comments
Closed

Building on iOS with the new architecture enabled fails. #326

psquizzle opened this issue Apr 22, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@psquizzle
Copy link

psquizzle commented Apr 22, 2024

I get the following errors but works with new arch not enabled. Using "@expensify/react-native-live-markdown": "^0.1.63"

[RUN_FASTLANE] › Compiling @expensify/react-native-live-markdown Pods/RNLiveMarkdown » RNLiveMarkdown-dummy.m
[RUN_FASTLANE] › Compiling @expensify/react-native-live-markdown Pods/RNLiveMarkdown » RCTBaseTextInputView+Markdown.m
[RUN_FASTLANE]
❌  (ios/Pods/Headers/Public/React-Fabric/react/renderer/components/view/AccessibilityPrimitives.h:10:10)

   8 | #pragma once
   9 |
> 10 | #include <cinttypes>
     |          ^ 'cinttypes' file not found
  11 | #include <optional>
  12 | #include <string>
  13 | #include <vector>

[RUN_FASTLANE]
❌  (ios/Pods/Headers/Public/glog/glog/logging.h:42:10)

  40 | #include <string.h>
  41 | #include <time.h>
> 42 | #include <iosfwd>
     |          ^ 'iosfwd' file not found
  43 | #include <ostream>
  44 | #include <sstream>
  45 | #include <string>

[RUN_FASTLANE] › Compiling @expensify/react-native-live-markdown Pods/RNLiveMarkdown » RCTUITextView+Markdown.mm
[RUN_FASTLANE] › Compiling @expensify/react-native-live-markdown Pods/RNLiveMarkdown » RCTTextInputComponentView+Markdown.mm
[RUN_FASTLANE] › Compiling @expensify/react-native-live-markdown Pods/RNLiveMarkdown » RCTMarkdownUtils.mm
[RUN_FASTLANE] ▸ ** ARCHIVE FAILED **
[RUN_FASTLANE] ▸ The following build commands failed:
[RUN_FASTLANE] ▸ 	CompileC /Users/peter/Library/Developer/Xcode/DerivedData/snipmap-dichtoroovopmbcnvhbwvywypevy/Build/Intermediates.noindex/ArchiveIntermediates/snipmap/IntermediateBuildFilesPath/Pods.build/Debug-iphoneos/RNLiveMarkdown.build/Objects-normal/arm64/RCTBaseTextInputView+Markdown.o /var/folders/rl/9tgdr27n0nj7lm5mt4t58tr80000gn/T/eas-build-local-nodejs/dcc53e11-373f-49b3-9ddb-74cad5236a75/build/node_modules/@expensify/react-native-live-markdown/ios/RCTBaseTextInputView+Markdown.m normal arm64 objective-c com.apple.compilers.llvm.clang.1_0.compiler (in target 'RNLiveMarkdown' from project 'Pods')
[RUN_FASTLANE] ▸ (1 failure)
[RUN_FASTLANE] ** ARCHIVE FAILED **
[RUN_FASTLANE]
[RUN_FASTLANE]
[RUN_FASTLANE] The following build commands failed:
[RUN_FASTLANE] 	CompileC /Users/peter/Library/Developer/Xcode/DerivedData/snipmap-dichtoroovopmbcnvhbwvywypevy/Build/Intermediates.noindex/ArchiveIntermediates/snipmap/IntermediateBuildFilesPath/Pods.build/Debug-iphoneos/RNLiveMarkdown.build/Objects-normal/arm64/RCTBaseTextInputView+Markdown.o /var/folders/rl/9tgdr27n0nj7lm5mt4t58tr80000gn/T/eas-build-local-nodejs/dcc53e11-373f-49b3-9ddb-74cad5236a75/build/node_modules/@expensify/react-native-live-markdown/ios/RCTBaseTextInputView+Markdown.m normal arm64 objective-c com.apple.compilers.llvm.clang.1_0.compiler (in target 'RNLiveMarkdown' from project 'Pods')
[RUN_FASTLANE] (1 failure)
[RUN_FASTLANE] Exit status: 65
@tomekzaw
Copy link
Collaborator

@psquizzle Can you check if 0.1.66 works for you? We've just merged #315 that should resolve this problem.

@tomekzaw tomekzaw added the bug Something isn't working label Apr 25, 2024
@psquizzle
Copy link
Author

@psquizzle Can you check if 0.1.66 works for you? We've just merged #315 that should resolve this problem.

So same error occurs when building with "@expensify/react-native-live-markdown": "^0.1.66" installed.

10 | #include
| ^ 'cinttypes' file not found
42 | #include
| ^ 'iosfwd' file not found
10 | #include
| ^ 'cinttypes' file not found

@tomekzaw
Copy link
Collaborator

@psquizzle Just to confirm, did you run RCT_NEW_ARCH_ENABLED=1 pod install after bumping version to 0.1.66?

@psquizzle
Copy link
Author

@psquizzle Just to confirm, did you run RCT_NEW_ARCH_ENABLED=1 pod install after bumping version to 0.1.66?

I am using the expo toolchain, and running npx expo prebuild --clean reinstalls pods and and generates the iOS folder dynamically. With the same error occurring. Turning off newArch the build works.

@tomekzaw
Copy link
Collaborator

@psquizzle We found the root cause of the problem, it was fixed in #331 and released in 0.1.67. Can you please check if it works for you?

@psquizzle
Copy link
Author

Cheers, builds and runs now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants