Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum checking of attributes #556

Open
rettigl opened this issue Feb 18, 2025 · 1 comment
Open

Enum checking of attributes #556

rettigl opened this issue Feb 18, 2025 · 1 comment

Comments

@rettigl
Copy link
Collaborator

rettigl commented Feb 18, 2025

Currently, attributes are not being checked against possible enumerations. This functionality should be added.

Steps to reproduce:
Follow the conversion notebook here: https://nomad-lab.eu/prod/v1/gui/user/uploads/upload/id/iM3-bEttS060E2-GIqaSBA
The @vector attributes of the transformation classes should be specific strings according to NXmpes_arpes, and the numeric values passed don't match these strings (see also #555). Instead, these should be checked agains the enumeration, and a warning be raised potentially.

@rettigl
Copy link
Collaborator Author

rettigl commented Feb 18, 2025

Possible fix in #557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant