Mark namefitted group as undocumented #570
Conversation
There was a problem hiding this comment.
This change seems to work, however it forces now the NAME[instance] notation also for variadic Fields. In fact, I support this, as previously namefitting was sometimes not correct.
One improvement I suggest is to add a separate clause for NXcollections. These can as I understand it appear anywhere:
"This is the NXcollection class which can appear anywhere underneath NXentry"
| # if not ignore_undocumented: | ||
| # collector.collect_and_log( | ||
| # not_visited_key, | ||
| # ValidationProblem.UnitWithoutDocumentation, | ||
| # mapping[not_visited_key], | ||
| # ) |
There was a problem hiding this comment.
This indeed referred to the parent field of an attribute, which gets checked separately. I think we can remove it entirely.
|
I used NXroot before to write nexus files w/o schema. These give warnings now, see igor-reader tests. Maybe this is fine. |
|
Mpes test failures are all with PROCESS_MPES, which should be removed anyways, so this will be resolved later. |
Ah no, NXroot contains NXentry. The issue is that we need ENTRY[scan...]/DATA[data]/DATA[data] now. |
@rettigl with this PR, we get an "is written without documentation" warning if a variadic concept name is used that is not part of the application definition.
I decided to reuse the undocumented warning here because this can be turned off with a flag in the CLI call of dataconverter. So if somebody is sure that they want to use this namefit anyway, we can just allow that by passing the `ignore-undocumented´ flag.
Fixes #563