Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Cleaning unused code #798 #15

Open
lucasgandac opened this issue Oct 7, 2021 · 3 comments
Open

[FEATURE] Cleaning unused code #798 #15

lucasgandac opened this issue Oct 7, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@lucasgandac
Copy link

Issue original
[FEATURE] Cleaning unused code #798

Is your feature request related to a problem? Please describe.
On some files in houdini, there are some unused code that might be deleted to improve code cleanliness.

Describe the solution you'd like
Remove old unused code.

Additional context
An example is index.tsx with commented eslint modules.

@lucasgandac lucasgandac added the enhancement New feature or request label Oct 7, 2021
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Thanks for submitting your first issue to Houdini!

@jpcirqueira jpcirqueira self-assigned this Feb 8, 2022
@lucasA27 lucasA27 self-assigned this Feb 8, 2022
@jpcirqueira
Copy link
Collaborator

It was not possible to remove code from lucasgandac we decided to look for other unused codes.

Codes have been removed:

  • Removed unused imports
  • Removed unused variables
  • Removed unnecessary async

@jpcirqueira
Copy link
Collaborator

some discussions were generated in the pull request ref: houdiniproject#1000, we sent a possible solution to the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants