Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPE environemnts stuck with 25 max steps #129

Closed
mariohevia opened this issue Jan 16, 2025 · 3 comments
Closed

MPE environemnts stuck with 25 max steps #129

mariohevia opened this issue Jan 16, 2025 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@mariohevia
Copy link

The implementation does not have a way of assigning the max_steps when creating an MPE environment. I believe this is a really small change, but it needs to be made for every simple_*.py file.

In addition, the current implementation of the baseline IPPO for MPE use higher max_steps which makes the environment start over in a single update and there is no reset between updates. I suspect this is the case for other baseline algorithms.

@amacrutherford
Copy link
Collaborator

amacrutherford commented Jan 20, 2025

hey! on max_steps, have you tried changing this argument?

On the baselines, yes that is the case.

@amacrutherford amacrutherford self-assigned this Jan 20, 2025
@mariohevia
Copy link
Author

Hi, the argument that you mention is for the base class of the MPE environments and it is not accessible when creating one of the MPE environments.

For example, the class SimpleReferenceMPE does not have this argument and is set by default to 25 by the base class. I can change it afterwards calling something like env.max_steps=new_value but this is cumbersome and I feel that it should be possible to set it when creating the environment.

@amacrutherford
Copy link
Collaborator

Ah yep seen! I'll get this fixed ASAP :)

@amacrutherford amacrutherford added the bug Something isn't working label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants