Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Expose block particles to FabricBakedModel #3161

Open
quat1024 opened this issue Jul 2, 2023 · 1 comment
Open

Request: Expose block particles to FabricBakedModel #3161

quat1024 opened this issue Jul 2, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@quat1024
Copy link

quat1024 commented Jul 2, 2023

FabricBakedModel defines a level-, pos-, and state-aware emitBlockQuads, and I am requesting that it also expose a level-, pos-, and state-aware version of BakedModel#getParticleIcon.

The use-case here is for "carpenter's blocks"-ish mods: it's very desirable to make the block's breaking, sprinting, and landing particles match the retextured model. It's typically not hard to implement this with a handful of mixins, but it'd be nice if this was part of FabricBakedModel, both to keep everything about the model in one place, and to potentially make it composable with other models w/ custom sprites (my simple mixins just end up calling the zero-arg vanilla getParticleIcon again). And, yknow, it'd be nice.

For comparison, Forge has an API like this on IForgeBakedModel. I think a simpler (level, pos, state) -> TextureAtlasSprite-shaped API would work fine too.

@Technici4n
Copy link
Member

Something like this is planned in the mid term. Whether it will be in the model or somewhere else has not been decided yet.

@Juuxel Juuxel added the enhancement New feature or request label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants